From f4bb16d5c2df7bf9135ab73cb42ec3a45533f679 Mon Sep 17 00:00:00 2001 From: Kapil Porwal Date: Fri, 17 Jan 2025 12:30:15 +0530 Subject: [PATCH] commonlib/dt: Fix recursive call for _dt_find_node Correctly call _dt_find_node recursively to avoid incorrect re-initialization of addrcp and sizecp. BUG=none TEST=Test coverage can pass. Change-Id: Icad075485f0a8a22138f1a0e1885405749ae5253 Signed-off-by: Kapil Porwal Reviewed-on: https://review.coreboot.org/c/coreboot/+/86029 Tested-by: build bot (Jenkins) Reviewed-by: Julius Werner Reviewed-by: Subrata Banik --- src/commonlib/device_tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/commonlib/device_tree.c b/src/commonlib/device_tree.c index a7007d9dd4..4d72fb0bbc 100644 --- a/src/commonlib/device_tree.c +++ b/src/commonlib/device_tree.c @@ -1074,7 +1074,7 @@ static struct device_tree_node *_dt_find_node(struct device_tree_node *parent, list_insert_after(&found->list_node, &parent->children); } - return dt_find_node(found, path + 1, addrcp, sizecp, create); + return _dt_find_node(found, path + 1, addrcp, sizecp, create); } /*