From f44b19f2dc4fd7a1f8b6894f6d3062d7630d8927 Mon Sep 17 00:00:00 2001 From: Simon Yang Date: Thu, 12 Jun 2025 13:44:01 +0800 Subject: [PATCH] soc/intel/pantherlake: Fix ACPI can't tag data node error On the Fatcat board, the following ACPI error message was observed. After applying the modification, the issue no longer appears. ACPI error message via dmesg: [ 0.209800] ACPI: Enabled 2 GPEs in block 00 to 7F [ 0.210654] ACPI: \: Can't tag data node [ 0.211039] ACPI: \: Can't tag data node [ 0.211430] ACPI: \: Can't tag data node [ 0.211672] ACPI: \: Can't tag data node [ 0.212052] ACPI: \: Can't tag data node BUG:None TEST:Run 'dmesg | grep -i "Can't tag data node" -A 10 -B 10' and cannot see the error messages anymore. Change-Id: I3da251b3c1950611fa0b4c125823f89d91dcd804 Signed-off-by: Simon Yang Reviewed-on: https://review.coreboot.org/c/coreboot/+/88065 Tested-by: build bot (Jenkins) Reviewed-by: Subrata Banik --- src/soc/intel/pantherlake/acpi/gpio.asl | 34 ++++++++++++------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/src/soc/intel/pantherlake/acpi/gpio.asl b/src/soc/intel/pantherlake/acpi/gpio.asl index 5aea294e61..06630109a7 100644 --- a/src/soc/intel/pantherlake/acpi/gpio.asl +++ b/src/soc/intel/pantherlake/acpi/gpio.asl @@ -229,13 +229,13 @@ Device (GPI0) Package (0x02) { "intc-gpio-group-0-subproperties", - GPPV + "GPPV" }, Package (0x02) { "intc-gpio-group-1-subproperties", - GPPC + "GPPC" } } }) @@ -371,13 +371,13 @@ Device (GPI1) Package (0x02) { "intc-gpio-group-0-subproperties", - GPPF + "GPPF" }, Package (0x02) { "intc-gpio-group-1-subproperties", - GPPE + "GPPE" }, } @@ -512,19 +512,19 @@ Device (GPI3) Package (0x02) { "intc-gpio-group-0-subproperties", - GPPH + "GPPH" }, Package (0x02) { "intc-gpio-group-1-subproperties", - GPPA + "GPPA" }, Package (0x02) { "intc-gpio-group-2-subproperties", - VGP3 + "VGP3" } } #else @@ -533,25 +533,25 @@ Device (GPI3) Package (0x02) { "intc-gpio-group-0-subproperties", - RSVD + "RSVD" }, Package (0x02) { "intc-gpio-group-1-subproperties", - GPPH + "GPPH" }, Package (0x02) { "intc-gpio-group-2-subproperties", - GPPA + "GPPA" }, Package (0x02) { "intc-gpio-group-3-subproperties", - VGP3 + "VGP3" } } #endif @@ -741,13 +741,13 @@ Device (GPI4) Package (0x02) { "intc-gpio-group-0-subproperties", - GPPS + "GPPS" }, Package (0x02) { "intc-gpio-group-1-subproperties", - RSVD + "RSVD" } } #else @@ -756,7 +756,7 @@ Device (GPI4) Package (0x02) { "intc-gpio-group-0-subproperties", - GPPS + "GPPS" } } #endif @@ -893,19 +893,19 @@ Device (GPI5) Package (0x02) { "intc-gpio-group-0-subproperties", - GPPB + "GPPB" }, Package (0x02) { "intc-gpio-group-1-subproperties", - GPPD + "GPPD" }, Package (0x02) { "intc-gpio-group-2-subproperties", - VGP0 + "VGP0" } } })