From f3f72bd198769456682744a12d17e34f16912c84 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Wed, 15 Jan 2025 09:15:53 +0530 Subject: [PATCH] mb/google/fatcat/var/fatcat: Workaround for codec enable with FPS There is an issue where the codec enable signal is not working correctly when FPS (Fingerprint Sensor) is enabled. This commit applies a temporary workaround by using a dedicated GPIO pin for codec enable. This allows the codec to function properly even when FPS is enabled, preventing audio issues. A proper fix in hardware schematics will be implemented in a future update. BUG=b:390031369 TEST=Verified audio playback works with FPS being enabled. Change-Id: I9883036b5e964cb55bd34c36398a501f69a8ecaa Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/85992 Tested-by: build bot (Jenkins) Reviewed-by: Pranava Y N Reviewed-by: Bora Guvendik --- src/mainboard/google/fatcat/variants/fatcat/fw_config.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mainboard/google/fatcat/variants/fatcat/fw_config.c b/src/mainboard/google/fatcat/variants/fatcat/fw_config.c index 0ba60485ae..3e6a192618 100644 --- a/src/mainboard/google/fatcat/variants/fatcat/fw_config.c +++ b/src/mainboard/google/fatcat/variants/fatcat/fw_config.c @@ -443,7 +443,12 @@ static const struct pad_config fp_disable_pads[] = { PAD_NC(GPP_C15, NONE), /* GPP_D01: MOD_TCSS1_TYP_A_VBUS_EN */ PAD_CFG_GPO(GPP_D01, 1, DEEP), - PAD_NC(GPP_E19, NONE), + /* FIXME: b/390031369 + * use dedicated GPIO PIN for codec enable + * when FPS is enabled. + */ + /* GPP_E19: CODEC_EN */ + PAD_CFG_GPO(GPP_E19, 1, PLTRST), PAD_NC(GPP_E20, NONE), PAD_NC(GPP_F14, NONE), PAD_NC(GPP_F15, NONE),