From f3db3a19d5cbd642d13816320e32785df9af26d6 Mon Sep 17 00:00:00 2001 From: Nicholas Sudsgaard Date: Thu, 7 Aug 2025 08:40:49 +0900 Subject: [PATCH] mb/51nb: Replace verb tables with reworked implementation No modifications/assumptions about the codecs were made on these boards. The Kconfigs were reverted using the following command: find src/mainboard/51nb -name 'Kconfig' | xargs git checkout main It should be noted that we do not modifiy the verb tables in any case, as it would break the regression test script mentioned in the TEST section below. For an overall rationale for this rework, see CB:88656. TEST= All boards passed regression test (CB:88763) Change-Id: Ib77a7d097b0ae68d250ebe0cb269249a587efcb3 Signed-off-by: Nicholas Sudsgaard Reviewed-on: https://review.coreboot.org/c/coreboot/+/88657 Reviewed-by: Angel Pons Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- src/mainboard/51nb/x210/Kconfig | 1 - src/mainboard/51nb/x210/hda_verb.c | 20 ++++++++++++++------ 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/src/mainboard/51nb/x210/Kconfig b/src/mainboard/51nb/x210/Kconfig index 5f880e01e6..a9d18074eb 100644 --- a/src/mainboard/51nb/x210/Kconfig +++ b/src/mainboard/51nb/x210/Kconfig @@ -4,7 +4,6 @@ if BOARD_51NB_X210 config BOARD_SPECIFIC_OPTIONS def_bool y - select AZALIA_USE_LEGACY_VERB_TABLE select BOARD_ROMSIZE_KB_8192 select EC_51NB_NPCE985LA0DX select HAVE_ACPI_RESUME diff --git a/src/mainboard/51nb/x210/hda_verb.c b/src/mainboard/51nb/x210/hda_verb.c index 730cc443a7..d689487582 100644 --- a/src/mainboard/51nb/x210/hda_verb.c +++ b/src/mainboard/51nb/x210/hda_verb.c @@ -2,12 +2,7 @@ #include -const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x14f15069, /* Codec Vendor / Device ID: Conexant CX20585 */ - 0x17aa2155, /* Subsystem ID */ - 12, /* Number of jacks (NID entries) */ - +static const u32 conexant_cx20585_verbs[] = { 0x0017ff00, /* Function Reset */ 0x0017ff00, /* Double Function Reset */ 0x0017ff00, @@ -36,4 +31,17 @@ const u32 cim_verb_data[] = { const u32 pc_beep_verbs[] = { }; + +struct azalia_codec mainboard_azalia_codecs[] = { + { + .name = "Conexant CX20585", + .vendor_id = 0x14f15069, + .subsystem_id = 0x17aa2155, + .address = 0, + .verbs = conexant_cx20585_verbs, + .verb_count = ARRAY_SIZE(conexant_cx20585_verbs), + }, + { /* terminator */ } +}; + AZALIA_ARRAY_SIZES;