From f1509a467ce317f10a453956930f503a5f49ca9b Mon Sep 17 00:00:00 2001
From: Matt DeVillier <matt.devillier@gmail.com>
Date: Thu, 17 Apr 2025 22:31:34 -0500
Subject: [PATCH] mb/starlabs/starfighter: Add CFR option to use native panel
 resolution

Add a CFR option to boot using the native panel resolution, rather than
a fixed/scaled video mode. This option selects between two VBT files:
one with the 'fixed mode' flag enabled, and one with it disabled.

This feature is mainly a workaround to a GNOME-related bug which
causes the creation of a 2nd display at the boot resolution. This
2nd display being a lower/different resolution than the native
panel resolution causes severe flickering/artifacting rendering
the display unusable unless this 2nd phantom display is disabled
on every boot.

Change-Id: I9e39258ce0171aab425150679d1ce30d69b2b1ef
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/87495
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-by: Alicja Michalska <ahplka19@gmail.com>
---
 src/mainboard/starlabs/starfighter/cfr.c         |   9 +++++++++
 src/mainboard/starlabs/starfighter/mainboard.c   |   9 +++++++++
 .../starfighter/variants/rpl/Makefile.mk         |   2 ++
 .../starfighter/variants/rpl/data_native_res.vbt | Bin 0 -> 9216 bytes
 4 files changed, 20 insertions(+)
 create mode 100644 src/mainboard/starlabs/starfighter/variants/rpl/data_native_res.vbt

diff --git a/src/mainboard/starlabs/starfighter/cfr.c b/src/mainboard/starlabs/starfighter/cfr.c
index e8522f10eb..bbef3a7c26 100644
--- a/src/mainboard/starlabs/starfighter/cfr.c
+++ b/src/mainboard/starlabs/starfighter/cfr.c
@@ -165,6 +165,14 @@ static const struct sm_object bluetooth_rtd3 = SM_DECLARE_BOOL({
 	.default_value	= true,
 });
 
+static const struct sm_object display_native_res = SM_DECLARE_BOOL({
+	.opt_name	= "display_native_res",
+	.ui_name	= "Display: Use Native Resolution",
+	.ui_helptext	= "Enabled: use the native panel resolution at boot.\n"
+			  "Disabled: use a fixed/scaled video mode at boot.",
+	.default_value	= false,
+});
+
 static struct sm_obj_form performance = {
 	.ui_name = "Performance",
 	.obj_list = (const struct sm_object *[]) {
@@ -213,6 +221,7 @@ static struct sm_obj_form devices = {
 		#if CONFIG(SOC_INTEL_TIGERLAKE) || CONFIG(SOC_INTEL_ALDERLAKE) || CONFIG(SOC_INTEL_RAPTORLAKE)
 		&gna,
 		#endif
+		&display_native_res,
 		#if CONFIG(EC_STARLABS_LID_SWITCH)
 		&lid_switch,
 		#endif
diff --git a/src/mainboard/starlabs/starfighter/mainboard.c b/src/mainboard/starlabs/starfighter/mainboard.c
index d394f2579d..e9c17e53ed 100644
--- a/src/mainboard/starlabs/starfighter/mainboard.c
+++ b/src/mainboard/starlabs/starfighter/mainboard.c
@@ -1,6 +1,7 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 
 #include <device/device.h>
+#include <drivers/intel/gma/opregion.h>
 #include <soc/ramstage.h>
 #include <option.h>
 #include <variants.h>
@@ -25,3 +26,11 @@ static void init_mainboard(void *chip_info)
 struct chip_operations mainboard_ops = {
 	.init = init_mainboard,
 };
+
+const char *mainboard_vbt_filename(void)
+{
+	if (get_uint_option("display_native_res", 0) == 1)
+		return "vbt_native_res.bin";
+
+	return "vbt.bin";
+}
diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/Makefile.mk b/src/mainboard/starlabs/starfighter/variants/rpl/Makefile.mk
index 2a505c35c7..53efc2f0fe 100644
--- a/src/mainboard/starlabs/starfighter/variants/rpl/Makefile.mk
+++ b/src/mainboard/starlabs/starfighter/variants/rpl/Makefile.mk
@@ -7,3 +7,5 @@ romstage-y += romstage.c
 ramstage-y += devtree.c
 ramstage-y += gpio.c
 ramstage-y += hda_verb.c
+
+$(call add_vbt_to_cbfs, vbt_native_res.bin, data_native_res.vbt)
diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/data_native_res.vbt b/src/mainboard/starlabs/starfighter/variants/rpl/data_native_res.vbt
new file mode 100644
index 0000000000000000000000000000000000000000..9020e8740d6c5e194e749680361434ccf102137a
GIT binary patch
literal 9216
zcmeHMUrbw782`?_ZRu)}PH^jR;u$Qg;DAfnkdY?b(t_*8pSCd4WhQj2Rf%j=#*`V8
zT_X=9i^)w)lr1J!6BC0E^5V07#O#I4Wbr{0-dq-6O!l_T`aAcQ*0LehIUTcK^WA%T
zzVH0b_x;Yf=bn4-{;}Rs?jH#DMF;%H`&z;rk|2fT`pY=pFTJ7Rk@28^)IZ)kFdR6}
z@6ax~zVEkNL<z?BINKGaJ#=n1Ipv8q@xked$*E*pFnRus+36Gy2SVI`=1g)bIdgh8
zncyR1FZ;Q`t90~Un4C)Rp$lgxk~7^LAPT&B`=Qp3L!5hGYEwGeyh{6FSi0LgyAL0!
zbOieX!-L__fPXYJJj92iJQy1BkBsyU_70rn;pp(uP;Y3oFIed)N+B?vx;QiW+Uv92
z6KLXI^wVPC8X@z*^h~Oi`=_RORQR0d(d7B$%v;GsYo$W~Wyo$}M9e`|8A3tGy<T#W
zoiwNgszNzb)JaeVB?g6+U?o@yR)Q4<s5nTMnFRX*JK5Z#YF*H$jB*AI`Fb5nTE1)+
zD$G*`xIAy-=<#}-TrO(ZC;B6To9HxyE;%|~7nN=pZaq1-%Joj;IX4jk0oimrm2;~y
zQ_4`P$j#^qoxYuO+eu_a>kMf{ZXys7+lM)~Y9gEArWd&xVZ!a}oSSF`+1RPzP@rAg
z=tf0oqG<_o_Z>Lp2x7#95IxJ(`<h;pSMIAjWpz*zIt{%DeINP(^ke8}(66B1K);24
z2mK!U6ZB{3uh1O{KuX3yJ*wjp#Bq)CS4K9wp2c=8IjiXyrn_wS&F?jGIYE^Dv}TEH
z=3gS;dWsJ?KNhy<TIJOW2d!4zW((DiXXyddZBkX3N1Hg5tIG^LBm<s$lH`se5V5cc
zDO5I(Sv6^mX*-`bZff=!C$6xV<TTE=nG0uY)d9+8Z|u-?zV^J!9<MiB*L7aP+AqpZ
zF2|&;5z<wh+GBgUN2|#rm@7Cr#oDwrLShf8eri<Q3!Nr{yYrH4Yyf~@C5u4t;by#f
z7D_WMMo3YW6z-=&kOdlwl5@^lTN1(?kJP$U*B=m=F7Du^B7E64w-%{wRAY;U7?>_@
z?&MT$%O%8cv`1AYmc6Q)DInOy?ga>A)>4>!b>G-hgzA)jJvSDDNnPy12%(h1!@I3|
zI$m3+Dm*t9VA7)RFk;XuO3A|G)6%Ks1|T$xR_0jf#!c6mw$7I@AFei~S0nTFO8Cm|
zJc3M5i87ch1wm<6SK{*t#T_x`fDwa?$s`c|=9~l%GGU7-5Ujj}EN<0OI?Q(~P9-2(
znK9_N9)X}$bQ$wOO!CcVwbZS--|T8pV=aZTkO})w5d*f&TVEGVD#bObj=NmgjtVid
zFt)1Bf&TD#`1HBt)X?d($tU2Cnc$;6X0tE0GuyEhvc;Aj-7&jCBuRP(nisKceHayM
z(!;2IgKWk5!6EvkA5I}`y-!e>5_FJ#L^oyJe(o5lA{|3^Z4goaAn;a&(L!FfN72k<
zJ)M93+<_%r!>wc)3*w<pEIT?@0b@bjKyWtOW3VokUJ>PL?jc(&q*a$*=&8XViox7W
zd_J;!CmZ`a88u9v^Ws5q+~XrJ+>OUcoXb5IxGS^$&(E;i%=|4>|MgN~WQt2RL%Ob;
zJAh)_Hve}d>aZDmt8Jb~Is7sMWd_O&lo=>9P-dXaK$(I6kb&;crM>jZ1fDr19j~h5
zw8oy#eccmZF^SYq@MTpd<{^z@@MU-{CnN*Cc@GDR%G|Vox7Uq$NoGR@u%K&S;N7%!
zktvjdkAil1mW5=X!Zv5+%mrJm#Z_d}e-ySg7NbSj8jEbJa}udGMN)yXZ1EP^?hY~<
zvo5iI(h*A?Y-XGq`uky(k#0+qLL8WN`8YGM=_e&TZ=1GdO9OH@KRXJWCCw;pU1edq
zLi2JxFwJLdVG}v1wiR+y1h$0mhMM_p#!CkF{gr~3G#=>@jl3JJ3cS<=MJ#UQ-a=iL
mmZCVXzK1W;c6<lNk8IV5#d!B`@cC!s_axXrTUq|E4Ezp%r*|#@

literal 0
HcmV?d00001