From f0d5b25e0233d28c9ac7c213a3d4487c62ce2dac Mon Sep 17 00:00:00 2001 From: Eren Peng Date: Tue, 29 Jul 2025 09:41:07 +0800 Subject: [PATCH] mb/google/trulo/var/kaladin: Add firmware name and gpio for ISH Add firmware name and update gpio pins GPP_B3 GPP_B4 for ISH bug=b:434789824,b:434858349 TEST=Flash and boot to OS on kaladin, tested sensors work fine and unit can enter s0ix Change-Id: Ia8dbf17a589a580116430cc4978b8d4ebbcf785e Signed-off-by: Eren Peng Reviewed-on: https://review.coreboot.org/c/coreboot/+/88597 Reviewed-by: Kyle Lin Tested-by: build bot (Jenkins) Reviewed-by: Kapil Porwal --- src/mainboard/google/brya/variants/kaladin/gpio.c | 8 ++++---- .../google/brya/variants/kaladin/overridetree.cb | 1 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/mainboard/google/brya/variants/kaladin/gpio.c b/src/mainboard/google/brya/variants/kaladin/gpio.c index 6f433bcd73..5dcac0a363 100644 --- a/src/mainboard/google/brya/variants/kaladin/gpio.c +++ b/src/mainboard/google/brya/variants/kaladin/gpio.c @@ -57,10 +57,10 @@ static const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_B1, NONE, DEEP, NF1), /* B2 : NC */ PAD_NC(GPP_B2, NONE), - /* B3 : IMU_INT_L */ - PAD_CFG_GPI_APIC(GPP_B3, NONE, PWROK, LEVEL, INVERT), - /* B4 : ACC_INT_L */ - PAD_CFG_GPI_APIC(GPP_B4, NONE, PWROK, LEVEL, INVERT), + /* B3 : ISH_IMU_INT_L */ + PAD_CFG_NF(GPP_B3, NONE, DEEP, NF4), + /* B4 : ISH_ACC_INT_L */ + PAD_CFG_NF(GPP_B4, NONE, DEEP, NF4), /* B5 : GPP_B5 ==> ISH_I2C0_SENSOR_SDA */ PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_B5, NONE, DEEP, NF1), /* B6 : GPP_B6 ==> ISH_I2C0_SENSOR_SCL */ diff --git a/src/mainboard/google/brya/variants/kaladin/overridetree.cb b/src/mainboard/google/brya/variants/kaladin/overridetree.cb index d6396afe55..4a8ad625c0 100644 --- a/src/mainboard/google/brya/variants/kaladin/overridetree.cb +++ b/src/mainboard/google/brya/variants/kaladin/overridetree.cb @@ -529,6 +529,7 @@ chip soc/intel/alderlake device ref heci1 on end device ref ish on chip drivers/intel/ish + register "firmware_name" = ""kaladin_ish.bin"" register "add_acpi_dma_property" = "true" device generic 0 on end end