From f0346845cd592ba59df6dc8843809f878ef17d08 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Tue, 2 Dec 2025 12:47:56 -0600 Subject: [PATCH] mb/google/reef: Add CFR option menu support Add CFR option menu support when using edk2 payload and SMMSTORE. Include relevant items from Apollolake SoC, Intel common, and ChromeEC. TEST=build/boot google/reef (electro), verify CFR option functionality. Change-Id: I8d9fdcaccc2d5cf35dcea6042f0a73d4bfd7ce69 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/90341 Reviewed-by: Jason Glenesk Tested-by: build bot (Jenkins) --- src/mainboard/google/reef/Kconfig | 1 + src/mainboard/google/reef/Makefile.mk | 1 + src/mainboard/google/reef/cfr.c | 42 +++++++++++++++++++++++++++ 3 files changed, 44 insertions(+) create mode 100644 src/mainboard/google/reef/cfr.c diff --git a/src/mainboard/google/reef/Kconfig b/src/mainboard/google/reef/Kconfig index d27feb2b49..899efeb4b8 100644 --- a/src/mainboard/google/reef/Kconfig +++ b/src/mainboard/google/reef/Kconfig @@ -7,6 +7,7 @@ config BOARD_GOOGLE_BASEBOARD_REEF select DRIVERS_I2C_DA7219 select DRIVERS_I2C_GENERIC select DRIVERS_I2C_HID + select DRIVERS_OPTION_CFR_ENABLED if PAYLOAD_EDK2 && SMMSTORE select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_BOARDID select EC_GOOGLE_CHROMEEC_LPC diff --git a/src/mainboard/google/reef/Makefile.mk b/src/mainboard/google/reef/Makefile.mk index accb4633f3..7633d79606 100644 --- a/src/mainboard/google/reef/Makefile.mk +++ b/src/mainboard/google/reef/Makefile.mk @@ -5,6 +5,7 @@ bootblock-y += ec.c romstage-$(CONFIG_CHROMEOS) += chromeos.c +ramstage-$(CONFIG_DRIVERS_OPTION_CFR) += cfr.c ramstage-$(CONFIG_CHROMEOS) += chromeos.c ramstage-y += ec.c ramstage-y += mainboard.c diff --git a/src/mainboard/google/reef/cfr.c b/src/mainboard/google/reef/cfr.c new file mode 100644 index 0000000000..bedb686b4e --- /dev/null +++ b/src/mainboard/google/reef/cfr.c @@ -0,0 +1,42 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include +#include +#include +#include +#include + +static struct sm_obj_form system = { + .ui_name = "System", + .obj_list = (const struct sm_object *[]) { + &legacy_8254_timer, + &me_state, + &me_state_counter, + &pciexp_aspm, + &pciexp_clk_pm, + &pciexp_l1ss, + &pciexp_speed, + &s0ix_enable, + &vtd, + NULL + }, +}; + +static struct sm_obj_form ec = { + .ui_name = "ChromeEC Embedded Controller", + .obj_list = (const struct sm_object *[]) { + &ec_kb_backlight, + NULL + }, +}; + +static struct sm_obj_form *sm_root[] = { + &system, + &ec, + NULL +}; + +void mb_cfr_setup_menu(struct lb_cfr *cfr_root) +{ + cfr_write_setup_menu(cfr_root, sm_root); +}