erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

UPSTREAM: fsp_Broadwell_DE: Do not set IRQ3 and IRQ4 to level

Browse source 
When booting Linux as a coreboot payload, serial access does not work
properly. This is because the setup code erroneously sets IRQ3 and
IRQ4 to level. The UART on Broadwell is 8250/16550 compatible, thus
ISA and edge-triggered.

This change is not necessary on the non-FSP version of Broadwell support.
The non-FSP version does not set these IRQ overrides.

Fix verified booting Linux 4.6.0-rc2 on Intel Camelback Mountain CRB,
using Intel FSP 1.0.

BUG=None
BRANCH=None
TEST=None

Signed-off-by: Kevin Paul Herbert <kevin@trippers.org>
Reviewed-on: https://review.coreboot.org/16065
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Change-Id: I17b466676e7f4891c3e75ce6208e1580c9eaf742
Reviewed-on: https://chromium-review.googlesource.com/369119
Commit-Ready: Furquan Shaikh <furquan@chromium.org>
Tested-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Kevin Paul Herbert 2016-08-04 14:35:30 -07:00 • committed by chrome-bot
commit ee3973864c
1 changed files with 0 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/soc/intel/fsp_broadwell_de/acpi.c
View file

@ -567,15 +567,5 @@ unsigned long acpi_madt_irq_overrides(unsigned long current)
current += acpi_create_madt_irqoverride(irqovr, 0, sci_irq, sci_irq,
sci_flags);
irqovr = (void *)current;
current += acpi_create_madt_irqoverride(irqovr, 0, 3, 3,
(MP_IRQ_TRIGGER_LEVEL
|MP_IRQ_POLARITY_LOW));
irqovr = (void *)current;
current += acpi_create_madt_irqoverride(irqovr, 0, 4, 4,
(MP_IRQ_TRIGGER_LEVEL
|MP_IRQ_POLARITY_LOW));
return current;
}