From ee1446a79164dae3031cf948c254f6b87b5c5b9c Mon Sep 17 00:00:00 2001 From: Benjamin Doron Date: Fri, 29 Aug 2025 11:38:42 -0400 Subject: [PATCH] mainboard/emulation/qemu-q35: Do not compile memmap into SMM This file contains functions related to PCIe and SMM, and so it's needed by bootblock and ramstage, and possibly romstage. It's not needed by SMM, and in a follow-up, the SMI handler will define `smm_region`, causing a function redefinition error. As this file isn't needed in SMM, and the SMI handler's function will work for this board too, as it works for all silicon (it returns values populated during ramstage, by board/silicon implementations of the function), drop this compilation unit from SMM. Change-Id: I0195e7d42b0669d675879fb4d2596aa4607095b9 Signed-off-by: Benjamin Doron Reviewed-on: https://review.coreboot.org/c/coreboot/+/88995 Reviewed-by: Paul Menzel Reviewed-by: Patrick Rudolph Tested-by: build bot (Jenkins) --- src/mainboard/emulation/qemu-q35/Makefile.mk | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mainboard/emulation/qemu-q35/Makefile.mk b/src/mainboard/emulation/qemu-q35/Makefile.mk index fc85e642b8..2ad19b92d6 100644 --- a/src/mainboard/emulation/qemu-q35/Makefile.mk +++ b/src/mainboard/emulation/qemu-q35/Makefile.mk @@ -21,5 +21,4 @@ all-y += ../qemu-i440fx/bootmode.c ramstage-$(CONFIG_CHROMEOS) += chromeos.c smm-y += ../qemu-i440fx/rom_media.c -smm-y += memmap.c smm-y += smihandler.c