From ede97ef9da9b34ed6d30bc57d4efa94bb3738676 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Sat, 20 Dec 2025 15:50:50 -0600 Subject: [PATCH] mb/google/volteer: Add IPUA device and sensor names Add missing configuration items for volteer variants to have functional MIPI cameras under Windows/mainline Linux: - Add IPUA device to graphics device configuration - Add sensor_name register to sensor device configurations Change-Id: Icd80ccc09b9c0436978d781fefb6ab85fbe71484 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/90580 Reviewed-by: Sean Rhodes Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai --- src/mainboard/google/volteer/Kconfig | 4 ++++ .../volteer/variants/voema/overridetree.cb | 15 +++++++++++++++ .../volteer/variants/volteer/overridetree.cb | 16 ++++++++++++++++ .../volteer/variants/volteer2/overridetree.cb | 16 ++++++++++++++++ 4 files changed, 51 insertions(+) diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index a32681d811..872d28540e 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -105,6 +105,7 @@ config BOARD_GOOGLE_TRONDO config BOARD_GOOGLE_VOEMA select BOARD_GOOGLE_BASEBOARD_VOLTEER + select DRIVERS_GFX_GENERIC select DRIVERS_INTEL_MIPI_CAMERA select INTEL_GMA_HAVE_VBT @@ -114,6 +115,7 @@ config BOARD_GOOGLE_VOLET config BOARD_GOOGLE_VOLTEER select BOARD_GOOGLE_BASEBOARD_VOLTEER + select DRIVERS_GFX_GENERIC select DRIVERS_INTEL_MIPI_CAMERA select INTEL_CAR_NEM select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES @@ -122,6 +124,7 @@ config BOARD_GOOGLE_VOLTEER2 select BOARD_GOOGLE_BASEBOARD_VOLTEER select DRIVER_I2C_TPM_ACPI select DRIVERS_GENESYSLOGIC_GL9755 + select DRIVERS_GFX_GENERIC select DRIVERS_INTEL_MIPI_CAMERA select INTEL_GMA_HAVE_VBT select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES @@ -130,6 +133,7 @@ config BOARD_GOOGLE_VOLTEER2_TI50 select BOARD_GOOGLE_BASEBOARD_VOLTEER select DRIVER_I2C_TPM_ACPI select DRIVERS_GENESYSLOGIC_GL9755 + select DRIVERS_GFX_GENERIC select DRIVERS_INTEL_MIPI_CAMERA select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES diff --git a/src/mainboard/google/volteer/variants/voema/overridetree.cb b/src/mainboard/google/volteer/variants/voema/overridetree.cb index ecb37987c7..6dce086fdc 100644 --- a/src/mainboard/google/volteer/variants/voema/overridetree.cb +++ b/src/mainboard/google/volteer/variants/voema/overridetree.cb @@ -9,6 +9,20 @@ chip soc/intel/tigerlake register "typec_aux_bias_pads[0]" = "{.pad_auxp_dc = GPP_E10, .pad_auxn_dc = GPP_E13}" device domain 0 on + device ref igpu on + chip drivers/gfx/generic + register "device_count" = "2" + # DDIA for eDP + register "device[0].name" = ""LCD0"" + register "device[0].type" = "panel" + # IPUA for IPU camera + register "device[1].name" = ""IPUA"" + register "device[1].non_vga_device" = "true" + register "device[1].addr" = "0x3480" + device generic 0 on end + end + end + device ref ipu on chip drivers/intel/mipi_camera register "acpi_uid" = "0x50000" @@ -80,6 +94,7 @@ chip soc/intel/tigerlake register "acpi_uid" = "0" register "acpi_name" = ""CAM1"" register "chip_name" = ""Ov 2740 Camera"" + register "sensor_name" = ""CJFLE23"" register "device_type" = "INTEL_ACPI_CAMERA_SENSOR" register "has_power_resource" = "true" diff --git a/src/mainboard/google/volteer/variants/volteer/overridetree.cb b/src/mainboard/google/volteer/variants/volteer/overridetree.cb index 21e6c63e55..9ffe08aa48 100644 --- a/src/mainboard/google/volteer/variants/volteer/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer/overridetree.cb @@ -63,6 +63,20 @@ chip soc/intel/tigerlake probe DB_USB USB4_GEN3 end + device ref igpu on + chip drivers/gfx/generic + register "device_count" = "2" + # DDIA for eDP + register "device[0].name" = ""LCD0"" + register "device[0].type" = "panel" + # IPUA for IPU cameras + register "device[1].name" = ""IPUA"" + register "device[1].non_vga_device" = "true" + register "device[1].addr" = "0x3480" + device generic 0 on end + end + end + device ref ipu on chip drivers/intel/mipi_camera register "acpi_uid" = "0x50000" @@ -185,6 +199,7 @@ chip soc/intel/tigerlake register "acpi_uid" = "0" register "acpi_name" = ""CAM1"" register "chip_name" = ""Ov 2740 Camera"" + register "sensor_name" = ""CJFLE23"" register "device_type" = "INTEL_ACPI_CAMERA_SENSOR" register "has_power_resource" = "true" register "low_power_probe" = "1" @@ -229,6 +244,7 @@ chip soc/intel/tigerlake register "acpi_uid" = "0" register "acpi_name" = ""CAM0"" register "chip_name" = ""Ov 8856 Camera"" + register "sensor_name" = ""CJAJ813"" register "device_type" = "INTEL_ACPI_CAMERA_SENSOR" register "has_power_resource" = "true" register "low_power_probe" = "1" diff --git a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb index f27bb77f98..782ebcb4c1 100644 --- a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb @@ -117,6 +117,20 @@ chip soc/intel/tigerlake probe DB_USB USB4_GEN3 end + device ref igpu on + chip drivers/gfx/generic + register "device_count" = "2" + # DDIA for eDP + register "device[0].name" = ""LCD0"" + register "device[0].type" = "panel" + # IPUA for IPU cameras + register "device[1].name" = ""IPUA"" + register "device[1].non_vga_device" = "true" + register "device[1].addr" = "0x3480" + device generic 0 on end + end + end + device ref ipu on chip drivers/intel/mipi_camera register "acpi_uid" = "0x50000" @@ -244,6 +258,7 @@ chip soc/intel/tigerlake register "acpi_uid" = "0" register "acpi_name" = ""CAM1"" register "chip_name" = ""Ov 2740 Camera"" + register "sensor_name" = ""CJFLE23"" register "device_type" = "INTEL_ACPI_CAMERA_SENSOR" register "has_power_resource" = "true" register "low_power_probe" = "1" @@ -288,6 +303,7 @@ chip soc/intel/tigerlake register "acpi_uid" = "0" register "acpi_name" = ""CAM0"" register "chip_name" = ""Ov 8856 Camera"" + register "sensor_name" = ""CJAJ813"" register "device_type" = "INTEL_ACPI_CAMERA_SENSOR" register "has_power_resource" = "true" register "low_power_probe" = "1"