From ece0072d1c48910b64167403230717f82db47b3e Mon Sep 17 00:00:00 2001 From: Luca Lai Date: Thu, 31 Jul 2025 19:06:01 +0800 Subject: [PATCH] mb/google/trulo/var/pujjolo: Update verb table to fix pop noise Because there is a pop noise when bios booting stage, so modify verb table to fix the issue. Change description by vendor: The Class-D K DC function has been added (which is the main solution this time), along with enabling silence detect to filter out noise below -84 dB to prevent it from being played through the speaker. BUG=b:430749506 TEST= Build and boot to OS, and check by EE and Realtek vendor. Change-Id: I3ac6cc82daf2ea78e73392ad67a5f4da131ddef5 Signed-off-by: Luca Lai Reviewed-on: https://review.coreboot.org/c/coreboot/+/88623 Reviewed-by: Subrata Banik Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai --- .../google/brya/variants/pujjolo/hda_verb.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/mainboard/google/brya/variants/pujjolo/hda_verb.c b/src/mainboard/google/brya/variants/pujjolo/hda_verb.c index d7f73667f6..ccbf6aacb4 100644 --- a/src/mainboard/google/brya/variants/pujjolo/hda_verb.c +++ b/src/mainboard/google/brya/variants/pujjolo/hda_verb.c @@ -6,7 +6,7 @@ const u32 cim_verb_data[] = { /* coreboot specific header */ 0x10ec0257, // Codec Vendor / Device ID: Realtek ALC257 0x10ec0257, // Subsystem ID - 0x00000011, // Number of jacks (NID entries) + 0x00000012, // Number of jacks (NID entries) AZALIA_RESET(0x1), /* NID 0x01, HDA Codec Subsystem ID Verb table */ @@ -35,6 +35,10 @@ const u32 cim_verb_data[] = { 0x0204C003, 0x0205001A, 0x0204C003, + 0x05850000, + 0x0584F880, + 0x05850000, + 0x0584F880, //==========Widget node 0x20 - 1 : ClassD 2W 0x02050038, 0x02048981, @@ -59,7 +63,7 @@ const u32 cim_verb_data[] = { 0x02050037, 0x0204FE15, 0x02050030, - 0x02041000, + 0x02049004, }; const u32 pc_beep_verbs[] = { @@ -73,6 +77,11 @@ const u32 pc_beep_verbs[] = { 0x0143B000, 0x01470C02, 0x01470C02, + /* Dos beep path - 3 */ + 0x0205000C, + 0x020401FF, + 0x00170503, + 0x00170503, }; AZALIA_ARRAY_SIZES;