erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/samsung/lumpy: Fix HDA pin configuration issues

Browse source 
Fix several HDA pin configuration issues:

- NID 0x06 (Internal Speaker): Disable jack presence detection.

- NID 0x08 (Unused): Standardize to AZALIA_PIN_CFG_NC(0) which
  generates the canonical NC value 0x411111f0 instead of the
  non-standard 0x77a70037.

- NID 0x09 (Internal Digital Mic): Disable jack presence detection.

This resolves an issue under Linux where the speakers would keep
outputting audio when the headphones were plugged in.

Change-Id: If9f5781200e2d2dc6c90713caf999868f7b993a0
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/90216
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
This commit is contained in:
Matt DeVillier 2025-11-25 11:15:08 -06:00
commit eb504eb49a
1 changed files with 3 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/mainboard/samsung/lumpy/hda_verb.c
View file

@ -38,7 +38,7 @@ const u32 cim_verb_data[] = {
AZALIA_SPEAKER,
AZALIA_OTHER_ANALOG,
AZALIA_COLOR_UNKNOWN,
AZALIA_JACK_PRESENCE_DETECT,
AZALIA_NO_JACK_PRESENCE_DETECT,
15,
0
)),
@ -56,16 +56,7 @@ const u32 cim_verb_data[] = {
)),
/* Pin Complex (NID 0x08) - Unused (NC) */
AZALIA_PIN_CFG(0, 0x08, AZALIA_PIN_DESC(
AZALIA_NC,
AZALIA_MOBILE_LID_INSIDE,
AZALIA_MIC_IN,
AZALIA_OTHER_ANALOG,
AZALIA_COLOR_UNKNOWN,
AZALIA_JACK_PRESENCE_DETECT,
3,
7
)),
AZALIA_PIN_CFG_NC(0),
/* Pin Complex (NID 0x09) - Internal Digital Mic */
AZALIA_PIN_CFG(0, 0x09, AZALIA_PIN_DESC(
@ -74,7 +65,7 @@ const u32 cim_verb_data[] = {
AZALIA_MIC_IN,
AZALIA_OTHER_DIGITAL,
AZALIA_COLOR_UNKNOWN,
AZALIA_JACK_PRESENCE_DETECT,
AZALIA_NO_JACK_PRESENCE_DETECT,
3,
14
)),