From ea6f150d9d11fef8f56ca8565de48c9944592e2b Mon Sep 17 00:00:00 2001 From: Jeremy Compostella Date: Thu, 12 Jun 2025 10:21:10 -0700 Subject: [PATCH] soc/intel/cmd/blk/cnvi: Correct conditional logic for CNVI readiness This commit fixes a bug in the conditional logic for determining Connectivity Integrated (CNVi) readiness in the `cnvw_fill_ssdt()` function. The comparison previously checked if `LOCAL3_OP` was equal to `1`, but it should instead verify if `LOCAL3_OP` equals `CNVI_READY`. This adjustment ensures the accurate assessment of CNVI's readiness state. TEST=Running the following "acpidbg -b 'set N \_SB.PCI0.CNVW.RSTT 1'", "acpidbg -b 'evaluate \_SB.PCI0.CNVW.CNVP._RST'" and "acpidbg -b 'evaluate \_SB.PCI0.CNVW.PRRS'" commands result in PRRS being read as 2 (expected) instead of 1. Change-Id: Ia6db833f3118e6975298aff4bd7c40657e4fcff7 Signed-off-by: Jeremy Compostella Reviewed-on: https://review.coreboot.org/c/coreboot/+/88088 Reviewed-by: Sean Rhodes Reviewed-by: Wonkyu Kim Tested-by: build bot (Jenkins) --- src/soc/intel/common/block/cnvi/cnvi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/intel/common/block/cnvi/cnvi.c b/src/soc/intel/common/block/cnvi/cnvi.c index 743b248476..5c5be9e1dd 100644 --- a/src/soc/intel/common/block/cnvi/cnvi.c +++ b/src/soc/intel/common/block/cnvi/cnvi.c @@ -310,7 +310,7 @@ static void cnvw_fill_ssdt(const struct device *dev) acpigen_write_if_lequal_op_int(LOCAL1_OP, 0); { - acpigen_write_if_lequal_op_int(LOCAL3_OP, 1); + acpigen_write_if_lequal_op_int(LOCAL3_OP, CNVI_READY); { acpigen_write_store_int_to_namestr(CNVI_PLDR_COMPLETE, "PRRS");