From e977560e725c2a8ff0e990bbf7d4d552a7e57ea8 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Mon, 28 Jul 2025 14:57:32 -0500 Subject: [PATCH] payloads/edk2: Increase non-full-screen menu size When the edk2 full-screen setup option is not used, the default console size is 80x25, which is far to small to effectively navigate the menus, especially now with many boards implementing CFR for setup options. Increase the default size from 80x25 to 128x40, which is a good middle ground for both low-res laptop displays and large external monitors. TEST=build/boot edk2 with full-screen setup option disabled on Starlabs starlite_adl and byte_twl with displays of varying resolution. Change-Id: I5ddcd06a66989b45f8f6e39a102298dc73b06c6d Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/88594 Reviewed-by: Paul Menzel Reviewed-by: Benjamin Doron Reviewed-by: Alicja Michalska Reviewed-by: Sean Rhodes Tested-by: build bot (Jenkins) Reviewed-by: Elyes Haouas --- payloads/external/edk2/Makefile | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/payloads/external/edk2/Makefile b/payloads/external/edk2/Makefile index f16aefd053..7c87c3469e 100644 --- a/payloads/external/edk2/Makefile +++ b/payloads/external/edk2/Makefile @@ -172,6 +172,11 @@ BUILD_STR += --pcd gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow=0 BUILD_STR += --pcd gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn=0 BUILD_STR += --pcd gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow=0 BUILD_STR += --pcd gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutColumn=0 +else +BUILD_STR += --pcd gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow=40 +BUILD_STR += --pcd gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn=128 +BUILD_STR += --pcd gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow=40 +BUILD_STR += --pcd gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutColumn=128 endif BUILD_STR += --pcd gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemId="COREv4"