From e94c2459d5f8d9a5ff19cb1a807affc9bb00c8b2 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Tue, 1 Apr 2025 21:17:05 +0100 Subject: [PATCH] mb/starlabs/starbook/adl_n: Tidy GPIO comments for display outputs This is a non-functional change, and only makes the GPIOs easier to read. Change-Id: Iaac4672fec3e282ffc3ea6acf07cfb56072ad850 Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/87075 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- .../starlabs/starbook/variants/adl_n/gpio.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c index 43ef9f23ab..2bcc4acc94 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c @@ -50,6 +50,13 @@ const struct pad_config gpio_table[] = { PAD_CFG_GPO(GPP_E3, 1, DEEP), /* WiFi RF Kill */ PAD_CFG_GPO(GPP_A13, 1, DEEP), /* Bluetooth RF Kill */ + /* Display */ + PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* eDP Hot Plug */ + PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), /* HDMI Hot Plug */ + PAD_CFG_NF(GPP_H15, NONE, DEEP, NF1), /* HDMI Clock */ + PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), /* HDMI Data */ + PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), /* TCP0 Hot Plug */ + PAD_NC(GPD2, NONE), PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ @@ -78,10 +85,6 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_A16, NONE), /* A17: Not Connected */ PAD_NC(GPP_A17, NONE), - /* A18: DDI B DP HPD */ - PAD_CFG_NF(GPP_A18, NONE, DEEP, NF1), - /* A19: TCP0 HPD */ - PAD_CFG_NF(GPP_A19, NONE, DEEP, NF1), /* A20: Test Point 44 */ PAD_NC(GPP_A20, NONE), /* A21: Fingerprint Reader Interrupt */ @@ -258,8 +261,6 @@ const struct pad_config gpio_table[] = { PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST), /* E13: Not connected */ PAD_NC(GPP_E13, NONE), - /* E14: EDP HPD */ - PAD_CFG_NF(GPP_E14, NONE, DEEP, NF1), /* E15: Not Connected */ PAD_NC(GPP_E15, NONE), /* E16: Not Connected */ @@ -352,12 +353,8 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_H13, NONE), /* H14: Not Connected */ PAD_NC(GPP_H14, NONE), - /* H15: DDPB Control Clock */ - PAD_CFG_NF(GPP_H15, NONE, DEEP, NF1), /* H16: Not Connected */ PAD_NC(GPP_H16, NONE), - /* H17: DDPB Control Data */ - PAD_CFG_NF(GPP_H17, NONE, DEEP, NF1), /* H18: CPI C10 Gate */ PAD_CFG_NF(GPP_H18, NONE, DEEP, NF1), /* H19: Clock Request 4 CPU M.2 SSD */