From e85a0b7ff1fa2e7c97211324957dc162b0b8baa0 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Sun, 23 Nov 2025 17:37:45 -0600 Subject: [PATCH] mb/google/puff: Remove unsupported EC features Remove EC feature definitions that are not supported by the puff EC firmware: - LID switch (CONFIG_LID_SWITCH is undefined) - PS/2 keyboard (CONFIG_CMD_KEYBOARD is undefined) - Keyboard backlight (not configured) Also remove corresponding host event masks from SCI, SMI, and wake event definitions. All of these were remnants from puff originally being part of the hatch mainboard, from which it was split off. TEST=build/boot google/puff/var/wyvern Change-Id: Idd86d4f342d29a25bd640d480cd5834e6250bcf0 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/90155 Reviewed-by: Sean Rhodes Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel --- .../variants/baseboard/include/baseboard/ec.h | 25 ++++--------------- 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/src/mainboard/google/puff/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/puff/variants/baseboard/include/baseboard/ec.h index a1a71c0fd0..451db39faa 100644 --- a/src/mainboard/google/puff/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/puff/variants/baseboard/include/baseboard/ec.h @@ -7,9 +7,7 @@ #include #define MAINBOARD_EC_SCI_EVENTS \ - (EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_CLOSED) |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_OPEN) |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_CONNECTED) |\ + (EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_CONNECTED) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_DISCONNECTED) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_LOW) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_BATTERY_CRITICAL) |\ @@ -21,21 +19,17 @@ EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE)) -#define MAINBOARD_EC_SMI_EVENTS \ - (EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_CLOSED)) +#define MAINBOARD_EC_SMI_EVENTS -/* EC can wake from S5 with lid or power button */ +/* EC can wake from S5 with power button */ #define MAINBOARD_EC_S5_WAKE_EVENTS \ - (EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_OPEN) |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_POWER_BUTTON)) + (EC_HOST_EVENT_MASK(EC_HOST_EVENT_POWER_BUTTON)) /* - * EC can wake from S3 with lid or power button or key press or - * mode change event. + * EC can wake from S3 with power button or mode change event. */ #define MAINBOARD_EC_S3_WAKE_EVENTS \ (MAINBOARD_EC_S5_WAKE_EVENTS |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEY_PRESSED) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE)) @@ -56,21 +50,12 @@ /* Enable EC backed PD MCU device in ACPI */ #define EC_ENABLE_PD_MCU_DEVICE -/* Enable LID switch and provide wake pin for EC */ -#define EC_ENABLE_LID_SWITCH #define EC_ENABLE_WAKE_PIN GPE_EC_WAKE -/* Enable Tablet switch */ -#define EC_ENABLE_TBMC_DEVICE - #define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ -#define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */ /* Enable EC sync interrupt, EC_SYNC_IRQ is defined in baseboard/gpio.h */ #define EC_ENABLE_SYNC_IRQ -/* Enable EC backed Keyboard Backlight in ACPI */ -#define EC_ENABLE_KEYBOARD_BACKLIGHT - #endif /* __BASEBOARD_EC_H__ */