From e7e9b874e1f1d7aac17fbbd208fa989bb481a643 Mon Sep 17 00:00:00 2001 From: Shawn Nematbakhsh Date: Wed, 26 Jun 2013 17:32:51 -0700 Subject: [PATCH] peppy: Flip RAM_ID GPIOs. RAM_ID0 was used as the table MSB, and RAM_ID2 as the LSB. This is the opposite of expected. Reverse these two GPIOS to make current boards work. For future boards, we will change the signal names on the schematic to be consistent. TEST=Manual. Build image, verify Hynix board loads correct SPD. BUG=chrome-os-partner:19636. BRANCH=None. Signed-off-by: Shawn Nematbakhsh Change-Id: I044e7ee696f19fe6fd5911e17317190832f675c5 Reviewed-on: https://gerrit.chromium.org/gerrit/60162 Tested-by: Shawn Nematbakhsh Reviewed-by: Dave Parker Commit-Queue: Dave Parker --- src/mainboard/google/peppy/gpio.h | 4 ++-- src/mainboard/google/peppy/romstage.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mainboard/google/peppy/gpio.h b/src/mainboard/google/peppy/gpio.h index dab086a0f8..dd186f8cc2 100644 --- a/src/mainboard/google/peppy/gpio.h +++ b/src/mainboard/google/peppy/gpio.h @@ -36,7 +36,7 @@ const struct pch_lp_gpio_map mainboard_gpio_map[] = { LP_GPIO_ACPI_SCI, /* 10: WLAN_WAKE_L_Q */ LP_GPIO_UNUSED, /* 11: UNUSED */ LP_GPIO_INPUT_INVERT, /* 12: TRACKPAD_INT_L (WAKE) */ - LP_GPIO_INPUT, /* 13: RAM_ID0 */ + LP_GPIO_INPUT, /* 13: RAM_ID2 */ LP_GPIO_INPUT, /* 14: EC_IN_RW */ LP_GPIO_UNUSED, /* 15: UNUSED (STRAP) */ LP_GPIO_UNUSED, /* 16: UNUSED */ @@ -70,7 +70,7 @@ const struct pch_lp_gpio_map mainboard_gpio_map[] = { LP_GPIO_OUT_HIGH, /* 44: PP3300_SSD_EN */ LP_GPIO_OUT_HIGH, /* 45: PP3300_CODEC_EN */ LP_GPIO_OUT_HIGH, /* 46: WLAN_DISABLE_L */ - LP_GPIO_INPUT, /* 47: RAM_ID2 */ + LP_GPIO_INPUT, /* 47: RAM_ID0 */ LP_GPIO_UNUSED, /* 48: UNUSED */ LP_GPIO_UNUSED, /* 49: UNUSED */ LP_GPIO_UNUSED, /* 50: UNUSED */ diff --git a/src/mainboard/google/peppy/romstage.c b/src/mainboard/google/peppy/romstage.c index bb65f005fe..080bf5434f 100644 --- a/src/mainboard/google/peppy/romstage.c +++ b/src/mainboard/google/peppy/romstage.c @@ -74,7 +74,7 @@ const struct rcba_config_instruction rcba_config[] = { /* Copy SPD data for on-board memory */ static void copy_spd(struct pei_data *peid) { - const int gpio_vector[] = {13, 9, 47, -1}; + const int gpio_vector[] = {47, 9, 13, -1}; int spd_index = get_gpios(gpio_vector); struct cbfs_file *spd_file;