erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/intel/cmn/acpi: Use Kconfig guards for UFS workarounds

Browse source 
This change introduces Kconfig guards around the UFS workaround code
in the common ACPI ASL file. This ensures that these workarounds are
only applied when necessary, allowing future SoCs with UFS controllers
to reuse the common ASL file without modification.

By using Kconfig, we can enable or disable the workarounds based on
the specific SoC configuration, providing greater flexibility and
maintainability.

BUG=b:379828045
TEST=Able to compile google/fatcat.

Change-Id: I968b8811e508378a36648bd8234ff0fd7237b00d
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85208
Reviewed-by: Pranava Y N <pranavayn@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Subrata Banik 2024-11-20 05:39:27 +00:00
commit e7264110a6
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/soc/intel/common/block/acpi/acpi/ufs.asl
View file

@ -28,6 +28,7 @@ Scope (\_SB.PCI0)
}
})
#if CONFIG(SOC_INTEL_UFS_OCP_TIMER_DISABLE)
/*
* OCP Timer need to be disabled in SCS UFS IOSF Bridge to work around
* the Silicon Issue due to which LTR mechanism doesn't work.
@ -47,6 +48,7 @@ Scope (\_SB.PCI0)
PCRA (PID_UFSX2, R_SCS_PCR_5820, 0x0)
PCRA (PID_UFSX2, R_SCS_PCR_1078, 0x0)
}
#endif
/* Memory Region to access to the UFS PCI Configuration Space */
OperationRegion(SCSR, PCI_Config, 0x00, 0x100)
@ -62,6 +64,7 @@ Scope (\_SB.PCI0)
PGEN, 1
}
#if CONFIG(SOC_INTEL_UFS_LTR_DISQUALIFY)
OperationRegion(PWMR, SystemMemory, PCH_PWRM_BASE_ADDRESS, PCH_PWRM_BASE_SIZE)
Field(PWMR, DWordAcc, NoLock, Preserve)
{
@ -73,6 +76,7 @@ Scope (\_SB.PCI0)
Method (ULTR, 1, Serialized) {
LTRU = Arg0
}
#endif
Method (_PS0, 0, Serialized)
{