erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ec/google/chromeec: Add RGB keyboard helper functions and enum

Browse source 
Add enum google_chromeec_rgbkbd_color with predefined color values
(OFF, RED, GREEN, BLUE, YELLOW, WHITE) and helper functions to
detect RGB keyboard support and set keyboard color. The color enum
is converted to RGB struct values internally for EC communication.

These will be used in a subsequent change adding support for setting
the RGB keyboard color at boot via CFR.

TEST=tested with rest of patch train.

Change-Id: I9afcbd8359e0fdc7c89e653165499f693367f5db
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/90159
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
This commit is contained in:
Matt DeVillier 2025-11-12 08:50:25 -06:00
commit e695731399
2 changed files with 92 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

80
src/ec/google/chromeec/ec.c
View file

@ -134,6 +134,86 @@ bool google_chromeec_has_kbbacklight(void)
}
}
static bool google_chromeec_rgb_color_to_struct(enum google_chromeec_rgbkbd_color color,
struct rgb_s *rgb)
{
switch (color) {
case GOOGLE_CHROMEEC_RGBKBD_COLOR_OFF:
*rgb = (struct rgb_s){ .r = 0x00, .g = 0x00, .b = 0x00 };
return true;
case GOOGLE_CHROMEEC_RGBKBD_COLOR_RED:
*rgb = (struct rgb_s){ .r = 0xFF, .g = 0x00, .b = 0x00 };
return true;
case GOOGLE_CHROMEEC_RGBKBD_COLOR_GREEN:
*rgb = (struct rgb_s){ .r = 0x00, .g = 0xFF, .b = 0x00 };
return true;
case GOOGLE_CHROMEEC_RGBKBD_COLOR_BLUE:
*rgb = (struct rgb_s){ .r = 0x00, .g = 0x00, .b = 0xFF };
return true;
case GOOGLE_CHROMEEC_RGBKBD_COLOR_YELLOW:
*rgb = (struct rgb_s){ .r = 0xFF, .g = 0xFF, .b = 0x00 };
return true;
case GOOGLE_CHROMEEC_RGBKBD_COLOR_WHITE:
*rgb = (struct rgb_s){ .r = 0xFF, .g = 0xFF, .b = 0xFF };
return true;
default:
printk(BIOS_DEBUG, "Chrome EC: Invalid RGB keyboard color: %d\n", color);
return false;
}
}
bool google_chromeec_has_rgbkbd(void)
{
struct ec_params_rgbkbd params = {
.subcmd = EC_RGBKBD_SUBCMD_GET_CONFIG,
};
struct ec_response_rgbkbd resp = {};
/* Query the EC to determine if RGB keyboard is supported. */
if (ec_cmd_rgbkbd(PLAT_EC, &params, &resp) == 0 &&
resp.rgbkbd_type != EC_RGBKBD_TYPE_UNKNOWN) {
printk(BIOS_DEBUG, "ChromeEC: RGB keyboard detected (type: %d)\n", resp.rgbkbd_type);
return true;
}
printk(BIOS_DEBUG, "Chrome EC: No RGB keyboard\n");
return false;
}
int google_chromeec_rgbkbd_set_color(enum google_chromeec_rgbkbd_color color)
{
struct rgb_s target_rgb;
if (!google_chromeec_rgb_color_to_struct(color, &target_rgb))
return -1;
/*
* Disable any demo mode so the keyboard will honour the static color
* we are about to set. Ignore failures in case older firmware doesn't
* implement the subcommand.
*/
struct ec_params_rgbkbd params = {
.subcmd = EC_RGBKBD_SUBCMD_DEMO,
.demo = EC_RGBKBD_DEMO_OFF,
};
struct ec_response_rgbkbd resp = {};
(void)ec_cmd_rgbkbd(PLAT_EC, &params, &resp);
params = (struct ec_params_rgbkbd){
.subcmd = EC_RGBKBD_SUBCMD_CLEAR,
.color = target_rgb,
};
if (ec_cmd_rgbkbd(PLAT_EC, &params, &resp) != 0)
return -1;
printk(BIOS_DEBUG, "Chrome EC: RGB keyboard color set to RGB %02x,%02x,%02x\n",
target_rgb.r, target_rgb.g, target_rgb.b);
return 0;
}
bool google_chromeec_has_fan(void)
{
/* Try the PWM fan feature flag (most reliable for modern ECs) */

12
src/ec/google/chromeec/ec.h
View file

@ -81,6 +81,18 @@ uint64_t google_chromeec_get_events_b(void);
int google_chromeec_clear_events_b(uint64_t mask);
int google_chromeec_kbbacklight(int percent);
bool google_chromeec_has_kbbacklight(void);
enum google_chromeec_rgbkbd_color {
GOOGLE_CHROMEEC_RGBKBD_COLOR_UNSET = -1,
GOOGLE_CHROMEEC_RGBKBD_COLOR_OFF = 0,
GOOGLE_CHROMEEC_RGBKBD_COLOR_RED,
GOOGLE_CHROMEEC_RGBKBD_COLOR_GREEN,
GOOGLE_CHROMEEC_RGBKBD_COLOR_BLUE,
GOOGLE_CHROMEEC_RGBKBD_COLOR_YELLOW,
GOOGLE_CHROMEEC_RGBKBD_COLOR_WHITE,
GOOGLE_CHROMEEC_RGBKBD_COLOR_COUNT,
};
int google_chromeec_rgbkbd_set_color(enum google_chromeec_rgbkbd_color color);
bool google_chromeec_has_rgbkbd(void);
bool google_chromeec_has_fan(void);
void google_chromeec_post(uint8_t postcode);
uint8_t google_chromeec_get_switches(void);