From e4fc00adbe5cc32fb366011aef1526bfbee901d8 Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Thu, 27 Feb 2025 10:00:21 +0100 Subject: [PATCH] soc/amd/common/block: Enable MMCONF first Enabling MMCONF is simple and should be done first to allow bootblock code to access the PCI config space. Required to cache ROM3 in early_cache_setup() that is now called directly after enabling MMCONF. Change-Id: I5d5f533258985211afafd9bf748f8e26f6128bd4 Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/c/coreboot/+/86619 Reviewed-by: Naresh Tested-by: build bot (Jenkins) --- src/soc/amd/common/block/cpu/noncar/bootblock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/amd/common/block/cpu/noncar/bootblock.c b/src/soc/amd/common/block/cpu/noncar/bootblock.c index e32499de04..419510ee6c 100644 --- a/src/soc/amd/common/block/cpu/noncar/bootblock.c +++ b/src/soc/amd/common/block/cpu/noncar/bootblock.c @@ -12,9 +12,9 @@ asmlinkage void bootblock_c_entry(uint64_t base_timestamp) { + enable_pci_mmconf(); early_cache_setup(); write_resume_eip(); - enable_pci_mmconf(); if (CONFIG(VBOOT_STARTS_BEFORE_BOOTBLOCK)) boot_with_psp_timestamp(base_timestamp);