erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

UPSTREAM: src/include: Open brace on same line as enum or struct

Browse source 
Fix the following errors and warning detected by checkpatch.pl:

ERROR: open brace '{' following enum go on the same line
ERROR: open brace '{' following struct go on the same line
ERROR: that open brace { should be on the previous line
WARNING: missing space after struct definition

TEST=Build and run on Galileo Gen2

Change-Id: Ieb89b152cebcf88cfde80b57bbaf9cf7130b8f04
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Original-Commit-Id: 6625ecc344
Original-Change-Id: I856235d0cc3a3e59376df52561b17b872b3416b2
Original-Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Original-Reviewed-on: https://review.coreboot.org/18653
Original-Tested-by: build bot (Jenkins)
Original-Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Original-Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-on: https://chromium-review.googlesource.com/453680
This commit is contained in:
Lee Leahy 2017-03-07 15:11:07 -08:00 • committed by chrome-bot
commit e4befad6d1
6 changed files with 26 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/include/device/i2c.h
View file

@ -32,8 +32,7 @@ enum i2c_address_mode {
I2C_MODE_10_BIT
};
struct i2c_seg
{
struct i2c_seg {
int read;
uint8_t chip;
uint8_t *buf;
@ -89,8 +88,10 @@ static inline int i2c_transfer(unsigned int bus, struct i2c_seg *segments,
static inline int i2c_read_raw(unsigned int bus, uint8_t chip, uint8_t *data,
int len)
{
struct i2c_seg seg =
{ .read = 1, .chip = chip, .buf = data, .len = len };
struct i2c_seg seg = {
.read = 1, .chip = chip, .buf = data, .len = len
};
return i2c_transfer(bus, &seg, 1);
}
@ -102,8 +103,10 @@ static inline int i2c_read_raw(unsigned int bus, uint8_t chip, uint8_t *data,
static inline int i2c_write_raw(unsigned int bus, uint8_t chip, uint8_t *data,
int len)
{
struct i2c_seg seg =
{ .read = 0, .chip = chip, .buf = data, .len = len };
struct i2c_seg seg = {
.read = 0, .chip = chip, .buf = data, .len = len
};
return i2c_transfer(bus, &seg, 1);
}

33
src/include/device/path.h
View file

@ -38,35 +38,29 @@ enum device_path_type {
"DEVICE_PATH_SPI", \
}
struct domain_path
{
struct domain_path {
unsigned int domain;
};
struct pci_path
{
struct pci_path {
unsigned int devfn;
};
struct pnp_path
{
struct pnp_path {
unsigned int port;
unsigned int device;
};
struct i2c_path
{
struct i2c_path {
unsigned int device;
unsigned int mode_10bit;
};
struct spi_path
{
struct spi_path {
unsigned int cs;
};
struct apic_path
{
struct apic_path {
unsigned int apic_id;
unsigned int package_id;
unsigned int node_id;
@ -74,28 +68,23 @@ struct apic_path
unsigned int thread_id;
};
struct ioapic_path
{
struct ioapic_path {
unsigned int ioapic_id;
};
struct cpu_cluster_path
{
struct cpu_cluster_path {
unsigned int cluster;
};
struct cpu_path
{
struct cpu_path {
unsigned int id;
};
struct cpu_bus_path
{
struct cpu_bus_path {
unsigned int id;
};
struct generic_path
{
struct generic_path {
unsigned int id;
unsigned int subid;
};