From e3cf1bc4ccba5fdcf4aaccfc24a5b9240492775f Mon Sep 17 00:00:00 2001 From: Dinesh Gehlot Date: Fri, 14 Feb 2025 20:05:51 +0530 Subject: [PATCH] mb/google/brya: Do not select HAVE_ACPI_RESUME This patch removes the HAVE_ACPI_RESUME config option from the Google Brya mainboard configuration. The Intel Alder Lake SoC does not support S3 (ACPI sleep state) entry/exit, and attempting S3 validation could lead to abnormal platform behavior. This change ensures that `_S3` is not listed as a valid wake source in the DSDT (Differentiated System Description Table) after booting to the OS. BUG=b:337274309 TEST=Boot verfied google/trulo. TEST=Veified that the _S3 name variable is not present in the DSDT ASL. Change-Id: Ic0dce9c7779333ca079001e3763e843a4aad9a81 Signed-off-by: Dinesh Gehlot Reviewed-on: https://review.coreboot.org/c/coreboot/+/86422 Reviewed-by: Matt DeVillier Reviewed-by: Eric Lai Reviewed-by: Subrata Banik Tested-by: build bot (Jenkins) --- src/mainboard/google/brya/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index aac2393017..1ca5094e92 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -28,7 +28,6 @@ config BOARD_GOOGLE_BRYA_COMMON select FW_CONFIG select FW_CONFIG_SOURCE_CHROMEEC_CBI select GOOGLE_SMBIOS_MAINBOARD_VERSION - select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select HAVE_FSP_LOGO_SUPPORT if RUN_FSP_GOP select I2C_TPM