From e22ff257d6bbcfe7497e705bc21c146bdddab4a9 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Fri, 7 Mar 2025 18:18:53 -0600 Subject: [PATCH] soc/intel/mtl/acpi: add entries for HEC1 and SRAM to DSDT MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit HEC1 and SRAM are defined in src/soc/intel/meteorlake/chipset.cb: device pci 16.0 alias heci1 on end device pci 14.2 alias pmc_shared_sram off end Add entries for these devices in DSDT to prevent "AE_NOT_FOUND" errors in the kernel dmesg log, and add entries to soc_acpi_name() to ensure that these names are returned during acpi_device_path() calls. TEST=Build/boot Linux 6.x on screebo to confirm errors are not seen. Change-Id: Id79054d2cb56daae238ac562b7b6c204926cdced Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/86797 Reviewed-by: Sean Rhodes Tested-by: build bot (Jenkins) Reviewed-by: Jérémy Compostella --- src/soc/intel/meteorlake/acpi/southbridge.asl | 6 ++++++ src/soc/intel/meteorlake/chip.c | 2 ++ 2 files changed, 8 insertions(+) diff --git a/src/soc/intel/meteorlake/acpi/southbridge.asl b/src/soc/intel/meteorlake/acpi/southbridge.asl index 5e8042e5b2..b205aff568 100644 --- a/src/soc/intel/meteorlake/acpi/southbridge.asl +++ b/src/soc/intel/meteorlake/acpi/southbridge.asl @@ -43,6 +43,12 @@ /* USB XHCI 0:14.0 */ #include "xhci.asl" +/* PMC Shared SRAM 0:14.2 */ +#include + +/* CSE/HECI #1 0:16.0 */ +#include + /* PCI _OSC */ #include diff --git a/src/soc/intel/meteorlake/chip.c b/src/soc/intel/meteorlake/chip.c index 79ef178dcc..a44a9b36cf 100644 --- a/src/soc/intel/meteorlake/chip.c +++ b/src/soc/intel/meteorlake/chip.c @@ -116,7 +116,9 @@ const char *soc_acpi_name(const struct device *dev) case PCI_DEVFN_HDA: return "HDAS"; case PCI_DEVFN_SMBUS: return "SBUS"; case PCI_DEVFN_GBE: return "GLAN"; + case PCI_DEVFN_SRAM: return "SRAM"; case PCI_DEVFN_SPI: return "FSPI"; + case PCI_DEVFN_CSE: return "HECI"; } printk(BIOS_DEBUG, "Missing ACPI Name for PCI: 00:%02x.%01x\n", PCI_SLOT(dev->path.pci.devfn), PCI_FUNC(dev->path.pci.devfn));