From e2216b3c433b1fa227a7576c5756878575f2ca61 Mon Sep 17 00:00:00 2001 From: Stefan Reinauer Date: Mon, 20 May 2013 15:21:48 -0700 Subject: [PATCH] exynos5420: Don't disable and re-enable the MMU when uncaching the framebuffer At one time it seemed to be necessary to disable and then re-enable the MMU when setting the framebuffer to be uncache-able due to bugs in the MMU management code. Since those bugs have been fixed, this is no longer necessary. BUG=None TEST=None BRANCH=None Change-Id: I1fb2bd6e14777470456e9517d3efba24c3b170a0 Signed-off-by: Gabe Black Signed-off-by: Stefan Reinauer Reviewed-on: https://gerrit.chromium.org/gerrit/55836 Reviewed-by: Gabe Black Reviewed-by: David Hendricks Commit-Queue: Stefan Reinauer --- src/cpu/samsung/exynos5420/cpu.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/cpu/samsung/exynos5420/cpu.c b/src/cpu/samsung/exynos5420/cpu.c index e83c16ad0a..1d511743b2 100644 --- a/src/cpu/samsung/exynos5420/cpu.c +++ b/src/cpu/samsung/exynos5420/cpu.c @@ -105,15 +105,11 @@ static void exynos_displayport_init(device_t dev) * Note: We may want to do something clever to ensure the framebuffer * region is aligned such that we don't change dcache policy for other * stuff inadvertantly. - * - * FIXME: Is disabling/re-enabling the MMU entirely necessary? */ uint32_t lower = ALIGN_DOWN(lcdbase, MiB); uint32_t upper = ALIGN_UP(lcdbase + fb_size, MiB); dcache_clean_invalidate_by_mva(lower, upper - lower); - dcache_mmu_disable(); mmu_config_range(lower/MiB, (upper - lower)/MiB, DCACHE_OFF); - dcache_mmu_enable(); mmio_resource(dev, 1, lcdbase/KiB, (fb_size + KiB - 1)/KiB); printk(BIOS_DEBUG,