erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ipq806x: move GPIO definitions to the proper include file

Browse source 
When the IPQ SPI driver was ported to coreboot, a few GPIO related
definitions ended up in a wrong include file. Move them to the proper
place and get rid of duplicated definition of GPIO_OUT.

BUG=chrome-os-partner:27784, chrome-os-partner:29871
TEST=proto0 still boots with the new firmware

Change-Id: I4b06067a71c85efaf0e48f29e232f83fd1f725a8
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/205328
Reviewed-by: Stefan Reinauer <reinauer@chromium.org>
Reviewed-by: Trevor Bourget <tbourget@codeaurora.org>
This commit is contained in:
Vadim Bendebury 2014-06-23 10:41:38 -07:00 • committed by chrome-internal-fetch
commit df73bb0023
3 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/soc/qualcomm/ipq806x/include/gpio.h
View file

@ -35,6 +35,14 @@
typedef unsigned int gpio_t;
#define GPIO_FUNC_ENABLE 1
#define GPIO_FUNC_DISABLE 0
#define FUNC_SEL_1 1
#define FUNC_SEL_3 3
#define FUNC_SEL_GPIO 0
#define GPIO_DRV_STR_10MA 0x4
#define GPIO_DRV_STR_11MA 0x7
/* GPIO TLMM: Direction */
#define GPIO_INPUT 0
#define GPIO_OUTPUT 1

8
src/soc/qualcomm/ipq806x/include/spi.h
View file

@ -229,14 +229,6 @@
#define GSBI7_SPI_MISO 7
#define GSBI7_SPI_MOSI 6
#define GPIO_FUNC_ENABLE 1
#define GPIO_FUNC_DISABLE 0
#define FUNC_SEL_1 1
#define FUNC_SEL_3 3
#define FUNC_SEL_GPIO 0
#define GPIO_DRV_STR_10MA 0x4
#define GPIO_DRV_STR_11MA 0x7
#define GPIO_OUT 1
#define MSM_GSBI_MAX_FREQ 51200000
#define SPI_RESET_STATE 0

4
src/soc/qualcomm/ipq806x/spi.c
View file

@ -277,9 +277,9 @@ static void CS_change(int port_num, int cs_num, int enable)
uint32_t addr = GPIO_IN_OUT_ADDR(cs_gpio);
uint32_t val = readl_i(addr);
val &= (~(1 << GPIO_OUT));
val &= (~(1 << GPIO_OUTPUT));
if (!enable)
val |= (1 << GPIO_OUT);
val |= (1 << GPIO_OUTPUT);
writel_i(val, addr);
}