erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Drop explicit NULL initializations from device_operations

Browse source 
Unmentioned fields are initialized with 0 (or NULL) implicitly. Beside
that, the struct has grown over the years. There are too many optional
fields to list them all.

Change-Id: Icb9e14c58153d7c14817bcde148e86e977666e4b
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40126
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Elyes HAOUAS 2020-04-04 12:26:35 +02:00 • committed by Nico Huber
commit deeccbf4e9
123 changed files with 0 additions and 207 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/northbridge/amd/agesa/family15tn/iommu.c
View file

@ -56,8 +56,6 @@ static struct device_operations iommu_ops = {
.read_resources = iommu_read_resources,
.set_resources = iommu_set_resources,
.enable_resources = pci_dev_enable_resources,
.init = 0,
.scan_bus = 0,
.ops_pci = &lops_pci,
};

2
src/northbridge/amd/agesa/family15tn/northbridge.c
View file

@ -563,8 +563,6 @@ static struct device_operations northbridge_operations = {
.init = DEVICE_NOOP,
.acpi_fill_ssdt = northbridge_fill_ssdt_generator,
.write_acpi_tables = agesa_write_acpi_tables,
.enable = 0,
.ops_pci = 0,
};
static const struct pci_driver family15_northbridge __pci_driver = {

2
src/northbridge/amd/agesa/family16kb/northbridge.c
View file

@ -562,8 +562,6 @@ static struct device_operations northbridge_operations = {
.init = DEVICE_NOOP,
.acpi_fill_ssdt = northbridge_fill_ssdt_generator,
.write_acpi_tables = agesa_write_acpi_tables,
.enable = 0,
.ops_pci = 0,
};
static const struct pci_driver family16_northbridge __pci_driver = {

2
src/northbridge/amd/pi/00630F01/iommu.c
View file

@ -56,8 +56,6 @@ static struct device_operations iommu_ops = {
.read_resources = iommu_read_resources,
.set_resources = iommu_set_resources,
.enable_resources = pci_dev_enable_resources,
.init = 0,
.scan_bus = 0,
.ops_pci = &lops_pci,
};

3
src/northbridge/amd/pi/00630F01/northbridge.c
View file

@ -557,8 +557,6 @@ static struct device_operations northbridge_operations = {
.init = DEVICE_NOOP,
.acpi_fill_ssdt = northbridge_fill_ssdt_generator,
.write_acpi_tables = agesa_write_acpi_tables,
.enable = 0,
.ops_pci = 0,
};
static const struct pci_driver family15_northbridge __pci_driver = {
@ -775,7 +773,6 @@ static struct device_operations pci_domain_ops = {
.read_resources = domain_read_resources,
.set_resources = domain_set_resources,
.enable_resources = domain_enable_resources,
.init = NULL,
.scan_bus = pci_domain_scan_bus,
};

3
src/northbridge/amd/pi/00660F01/northbridge.c
View file

@ -547,8 +547,6 @@ static struct device_operations northbridge_operations = {
.init = northbridge_init,
.acpi_fill_ssdt = northbridge_fill_ssdt_generator,
.write_acpi_tables = agesa_write_acpi_tables,
.enable = 0,
.ops_pci = 0,
};
static const struct pci_driver family15_northbridge __pci_driver = {
@ -784,7 +782,6 @@ static struct device_operations pci_domain_ops = {
.read_resources = domain_read_resources,
.set_resources = domain_set_resources,
.enable_resources = domain_enable_resources,
.init = NULL,
.scan_bus = pci_domain_scan_bus,
.acpi_name = domain_acpi_name,
};

2
src/northbridge/amd/pi/00730F01/iommu.c
View file

@ -46,8 +46,6 @@ static struct device_operations iommu_ops = {
.read_resources = iommu_read_resources,
.set_resources = iommu_set_resources,
.enable_resources = pci_dev_enable_resources,
.init = 0,
.scan_bus = 0,
.ops_pci = &lops_pci,
};

3
src/northbridge/amd/pi/00730F01/northbridge.c
View file

@ -777,8 +777,6 @@ static struct device_operations northbridge_operations = {
.init = northbridge_init,
.acpi_fill_ssdt = northbridge_fill_ssdt_generator,
.write_acpi_tables = agesa_write_acpi_tables,
.enable = 0,
.ops_pci = 0,
};
static const struct pci_driver family16_northbridge __pci_driver = {
@ -1048,7 +1046,6 @@ static struct device_operations pci_domain_ops = {
.read_resources = domain_read_resources,
.set_resources = domain_set_resources,
.enable_resources = domain_enable_resources,
.init = NULL,
.scan_bus = pci_domain_scan_bus,
.acpi_name = domain_acpi_name,
};

3
src/northbridge/intel/e7505/northbridge.c
View file

@ -80,8 +80,6 @@ static struct pci_operations intel_pci_ops = {
static struct device_operations pci_domain_ops = {
.read_resources = mch_domain_read_resources,
.set_resources = mch_domain_set_resources,
.enable_resources = NULL,
.init = NULL,
.scan_bus = pci_domain_scan_bus,
.ops_pci = &intel_pci_ops,
};
@ -96,7 +94,6 @@ static struct device_operations cpu_bus_ops = {
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
.init = cpu_bus_init,
.scan_bus = 0,
};
static void enable_dev(struct device *dev)

2
src/northbridge/intel/gm45/gma.c
View file

@ -267,8 +267,6 @@ static struct device_operations gma_func0_ops = {
.enable_resources = pci_dev_enable_resources,
.acpi_fill_ssdt = gma_generate_ssdt,
.init = gma_func0_init,
.scan_bus = 0,
.enable = 0,
.ops_pci = &gma_pci_ops,
.acpi_name = gma_acpi_name,
.write_acpi_tables = gma_write_acpi_tables,

2
src/northbridge/intel/gm45/northbridge.c
View file

@ -229,7 +229,6 @@ void northbridge_write_smram(u8 smram)
static struct device_operations pci_domain_ops = {
.read_resources = mch_domain_read_resources,
.set_resources = mch_domain_set_resources,
.enable_resources = NULL,
.init = mch_domain_init,
.scan_bus = pci_domain_scan_bus,
.write_acpi_tables = northbridge_write_acpi_tables,
@ -242,7 +241,6 @@ static struct device_operations cpu_bus_ops = {
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
.init = mp_cpu_bus_init,
.scan_bus = 0,
};
static void enable_dev(struct device *dev)

2
src/northbridge/intel/haswell/gma.c
View file

@ -565,8 +565,6 @@ static struct device_operations gma_func0_ops = {
.enable_resources = pci_dev_enable_resources,
.init = gma_func0_init,
.acpi_fill_ssdt = gma_generate_ssdt,
.scan_bus = NULL,
.enable = NULL,
.ops_pci = &gma_pci_ops,
.write_acpi_tables = gma_write_acpi_tables,
};

1
src/northbridge/intel/haswell/minihd.c
View file

@ -106,7 +106,6 @@ static struct device_operations minihd_ops = {
.set_resources = pci_dev_set_resources,
.enable_resources = pci_dev_enable_resources,
.init = minihd_init,
.scan_bus = NULL,
.ops_pci = &minihd_pci_ops,
};

4
src/northbridge/intel/haswell/northbridge.c
View file

@ -92,8 +92,6 @@ static const char *northbridge_acpi_name(const struct device *dev)
static struct device_operations pci_domain_ops = {
.read_resources = pci_domain_read_resources,
.set_resources = pci_domain_set_resources,
.enable_resources = NULL,
.init = NULL,
.scan_bus = pci_domain_scan_bus,
.acpi_name = northbridge_acpi_name,
.write_acpi_tables = northbridge_write_acpi_tables,
@ -477,7 +475,6 @@ static struct device_operations mc_ops = {
.enable_resources = pci_dev_enable_resources,
.init = northbridge_init,
.acpi_fill_ssdt = generate_cpu_entries,
.scan_bus = NULL,
.ops_pci = &intel_pci_ops,
};
@ -500,7 +497,6 @@ static struct device_operations cpu_bus_ops = {
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
.init = mp_cpu_bus_init,
.scan_bus = NULL,
};
static void enable_dev(struct device *dev)

5
src/northbridge/intel/i440bx/northbridge.c
View file

@ -31,8 +31,6 @@ static struct device_operations northbridge_operations = {
.set_resources = pci_dev_set_resources,
.enable_resources = pci_dev_enable_resources,
.init = northbridge_init,
.enable = 0,
.ops_pci = 0,
};
static const struct pci_driver northbridge_driver __pci_driver = {
@ -82,8 +80,6 @@ static void i440bx_domain_set_resources(struct device *dev)
static struct device_operations pci_domain_ops = {
.read_resources = pci_domain_read_resources,
.set_resources = i440bx_domain_set_resources,
.enable_resources = NULL,
.init = NULL,
.scan_bus = pci_domain_scan_bus,
};
@ -97,7 +93,6 @@ static struct device_operations cpu_bus_ops = {
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
.init = cpu_bus_init,
.scan_bus = 0,
};
static void enable_dev(struct device *dev)

4
src/northbridge/intel/i945/gma.c
View file

@ -816,8 +816,6 @@ static struct device_operations gma_func0_ops = {
.enable_resources = pci_dev_enable_resources,
.init = gma_func0_init,
.acpi_fill_ssdt = gma_generate_ssdt,
.scan_bus = 0,
.enable = 0,
.disable = gma_func0_disable,
.ops_pci = &gma_pci_ops,
.acpi_name = gma_acpi_name,
@ -830,8 +828,6 @@ static struct device_operations gma_func1_ops = {
.set_resources = pci_dev_set_resources,
.enable_resources = pci_dev_enable_resources,
.init = gma_func1_init,
.scan_bus = 0,
.enable = 0,
.ops_pci = &gma_pci_ops,
};

4
src/northbridge/intel/i945/northbridge.c
View file

@ -167,8 +167,6 @@ void northbridge_write_smram(u8 smram)
static struct device_operations pci_domain_ops = {
.read_resources = mch_domain_read_resources,
.set_resources = mch_domain_set_resources,
.enable_resources = NULL,
.init = NULL,
.scan_bus = pci_domain_scan_bus,
.acpi_name = northbridge_acpi_name,
};
@ -196,7 +194,6 @@ static struct device_operations mc_ops = {
.set_resources = pci_dev_set_resources,
.enable_resources = pci_dev_enable_resources,
.acpi_fill_ssdt = generate_cpu_entries,
.scan_bus = 0,
.ops_pci = &intel_pci_ops,
};
@ -216,7 +213,6 @@ static struct device_operations cpu_bus_ops = {
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
.init = mp_cpu_bus_init,
.scan_bus = 0,
};
static void enable_dev(struct device *dev)

2
src/northbridge/intel/ironlake/gma.c
View file

@ -257,8 +257,6 @@ static struct device_operations gma_func0_ops = {
.enable_resources = pci_dev_enable_resources,
.acpi_fill_ssdt = gma_generate_ssdt,
.init = gma_func0_init,
.scan_bus = 0,
.enable = 0,
.ops_pci = &gma_pci_ops,
.write_acpi_tables = gma_write_acpi_tables,
};

4
src/northbridge/intel/ironlake/northbridge.c
View file

@ -105,8 +105,6 @@ static const char *northbridge_acpi_name(const struct device *dev)
static struct device_operations pci_domain_ops = {
.read_resources = pci_domain_read_resources,
.set_resources = pci_domain_set_resources,
.enable_resources = NULL,
.init = NULL,
.scan_bus = pci_domain_scan_bus,
#if CONFIG(HAVE_ACPI_TABLES)
.acpi_name = northbridge_acpi_name,
@ -256,7 +254,6 @@ static struct device_operations mc_ops = {
.enable_resources = pci_dev_enable_resources,
.init = northbridge_init,
.acpi_fill_ssdt = generate_cpu_entries,
.scan_bus = 0,
.ops_pci = &intel_pci_ops,
};
@ -271,7 +268,6 @@ static struct device_operations cpu_bus_ops = {
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
.init = mp_cpu_bus_init,
.scan_bus = 0,
};
static void enable_dev(struct device *dev)

3
src/northbridge/intel/pineview/gma.c
View file

@ -326,10 +326,7 @@ static struct device_operations gma_func0_ops = {
.read_resources = pci_dev_read_resources,
.set_resources = pci_dev_set_resources,
.enable_resources = pci_dev_enable_resources,
.acpi_fill_ssdt = NULL,
.init = gma_func0_init,
.scan_bus = NULL,
.enable = NULL,
.ops_pci = &gma_pci_ops,
.acpi_name = gma_acpi_name,
.write_acpi_tables = gma_write_acpi_tables,

2
src/northbridge/intel/sandybridge/gma.c
View file

@ -699,8 +699,6 @@ static struct device_operations gma_func0_ops = {
.enable_resources = pci_dev_enable_resources,
.acpi_fill_ssdt = gma_generate_ssdt,
.init = gma_func0_init,
.scan_bus = NULL,
.enable = NULL,
.disable = gma_func0_disable,
.ops_pci = &gma_pci_ops,
.acpi_name = gma_acpi_name,

4
src/northbridge/intel/sandybridge/northbridge.c
View file

@ -245,8 +245,6 @@ static const char *northbridge_acpi_name(const struct device *dev)
static struct device_operations pci_domain_ops = {
.read_resources = pci_domain_read_resources,
.set_resources = pci_domain_set_resources,
.enable_resources = NULL,
.init = NULL,
.scan_bus = pci_domain_scan_bus,
.write_acpi_tables = northbridge_write_acpi_tables,
.acpi_name = northbridge_acpi_name,
@ -444,7 +442,6 @@ static struct device_operations mc_ops = {
.set_resources = pci_dev_set_resources,
.enable_resources = pci_dev_enable_resources,
.init = northbridge_init,
.scan_bus = NULL,
.ops_pci = &intel_pci_ops,
.acpi_fill_ssdt = generate_cpu_entries,
};
@ -466,7 +463,6 @@ static struct device_operations cpu_bus_ops = {
.set_resources = DEVICE_NOOP,
.enable_resources = DEVICE_NOOP,
.init = mp_cpu_bus_init,
.scan_bus = 0,
};
static void enable_dev(struct device *dev)