From ddf4748c221e2d11ee186193bdd81cb65551a93e Mon Sep 17 00:00:00 2001 From: Uwe Poeche Date: Fri, 9 Jan 2026 12:27:16 +0100 Subject: [PATCH] mb/siemens/mc_ehl7: Deactivate RTC On this mainboard no RTC is assembled. Therefore, it is deactivated. TEST=Boot into OS and verify if relevant I2C Controller is disabled and no error in coreboot log is shown. Change-Id: I23b4a735a09686fa2636280d7b410db59d884c49 Signed-off-by: Uwe Poeche Reviewed-on: https://review.coreboot.org/c/coreboot/+/90715 Tested-by: build bot (Jenkins) Reviewed-by: Mario Scheithauer --- .../siemens/mc_ehl/variants/mc_ehl7/Kconfig | 1 - .../mc_ehl/variants/mc_ehl7/devicetree.cb | 23 +------------------ 2 files changed, 1 insertion(+), 23 deletions(-) diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl7/Kconfig b/src/mainboard/siemens/mc_ehl/variants/mc_ehl7/Kconfig index 7cc7c5abee..6ce0b48052 100644 --- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl7/Kconfig +++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl7/Kconfig @@ -6,7 +6,6 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select DRIVER_INTEL_I210 select DRIVERS_ETH_PHY_M88E1512 - select DRIVERS_I2C_RV3028C7 select EHL_TSN_DRIVER select MAINBOARD_HAS_TPM2 select MEMORY_MAPPED_TPM diff --git a/src/mainboard/siemens/mc_ehl/variants/mc_ehl7/devicetree.cb b/src/mainboard/siemens/mc_ehl/variants/mc_ehl7/devicetree.cb index 5180770908..776eab22e3 100644 --- a/src/mainboard/siemens/mc_ehl/variants/mc_ehl7/devicetree.cb +++ b/src/mainboard/siemens/mc_ehl/variants/mc_ehl7/devicetree.cb @@ -95,7 +95,7 @@ chip soc/intel/elkhartlake # LPSS Serial IO (I2C/UART/GSPI) related UPDs register "SerialIoI2cMode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoDisabled, - [PchSerialIoIndexI2C1] = PchSerialIoPci, + [PchSerialIoIndexI2C1] = PchSerialIoDisabled, [PchSerialIoIndexI2C2] = PchSerialIoPci, [PchSerialIoIndexI2C3] = PchSerialIoDisabled, [PchSerialIoIndexI2C4] = PchSerialIoPci, @@ -105,7 +105,6 @@ chip soc/intel/elkhartlake }" register "SerialIoI2cPadsTermination" = "{ - [PchSerialIoIndexI2C1] = 1, [PchSerialIoIndexI2C2] = 1, [PchSerialIoIndexI2C4] = 1, [PchSerialIoIndexI2C6] = 1, @@ -155,26 +154,6 @@ chip soc/intel/elkhartlake device pci 14.0 on end # USB3.1 xHCI - device pci 15.1 on # I2C1 - # Enable external RTC chip - chip drivers/i2c/rv3028c7 - register "bus_speed" = "I2C_SPEED_STANDARD" - register "set_user_date" = "1" - register "user_year" = "04" - register "user_month" = "07" - register "user_day" = "01" - register "user_weekday" = "4" - register "bckup_sw_mode" = "BACKUP_SW_LEVEL" - register "cap_charge" = "CHARGE_OFF" - device i2c 0x52 on end # RTC RV3028-C7 - end - # Add dummy I2C device to limit BUS speed to 100 kHz in OS - chip drivers/i2c/generic - register "hid" = ""PRP0001"" - register "speed" = "I2C_SPEED_STANDARD" - device i2c 0x7f on end - end - end device pci 15.2 on # I2C2 # Add dummy I2C device to limit BUS speed to 100 kHz in OS chip drivers/i2c/generic