From d9d06f7d79fcd5b5b0638cfb18a67aab4c77fab6 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Sun, 9 Mar 2025 15:42:27 +0530 Subject: [PATCH] soc/qualcomm/cmn/qclib: Replace magic number with BIT() macro Replace the magic number 0x00000001 with the BIT(0) macro for QCLIB_GA_ENABLE_UART_LOGGING. This improves readability and maintainability by clearly indicating that a specific bit is being set. TEST=Able to build google/herobrine. Change-Id: Ie425a68c6721343ca53eb883d6278decca92bcad Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/86774 Tested-by: build bot (Jenkins) Reviewed-by: Dinesh Gehlot Reviewed-by: Julius Werner --- src/soc/qualcomm/common/include/soc/qclib_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/qualcomm/common/include/soc/qclib_common.h b/src/soc/qualcomm/common/include/soc/qclib_common.h index 792b743f40..850202a490 100644 --- a/src/soc/qualcomm/common/include/soc/qclib_common.h +++ b/src/soc/qualcomm/common/include/soc/qclib_common.h @@ -43,7 +43,7 @@ struct qclib_cb_if_table_entry { }; /* GA_BMASK_VALUES (global_attributes bit mask values) */ -#define QCLIB_GA_ENABLE_UART_LOGGING 0x00000001 +#define QCLIB_GA_ENABLE_UART_LOGGING BIT(0) #define QCLIB_GA_FORCE_COLD_REBOOT BIT(3) #define QCLIB_GA_DDR_FMAX_LIMIT_HYNIX8GB BIT(5)