erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

drivers/wifi/generic: Implement Wi-Fi PRR DSM functions

Browse source 
This commit introduces Power Resource for Reset (PRR) Device-Specific
Methods (DSM) "7266172c-220b-4b29-814f-75e4dd26b5fd" functions 2 and 5,
enabling access to the Power Resource Reset mode, status and delay. It
meets the DSM requirements listed in Intel Document number 559910. The
Power Resource Advanced Configuration and Power Interface (ACPI) code
was adapted from Panther Lake (PTL) Firmware Support Package (FSP)
revision 3144.01 (IntelWifiDsmFunc2.asl and IntelWifiDsmFunc5.dsl).

TEST=The following sequence of acpidbg commands was used to verify
     functions 2 and 5 behavior on a Fatcat device.
     acpidbg -b "evaluate \_SB.PCI0.CNVW._DSM \
             (2c 17 66 72 0b 22 29 4b 81 4f 75 e4 dd 26 b5 fd) \
             0 2 (01 00 00 00)" # Get PRR mode (type): 0x0
     acpidbg -b "evaluate \_SB.PCI0.CNVW._DSM \
             (2c 17 66 72 0b 22 29 4b 81 4f 75 e4 dd 26 b5 fd) \
             0 2 (02 00 01 00)" # Set PRR mode (type) to 0x1
     acpidbg -b "evaluate \_SB.PCI0.CNVW._DSM \
             (2c 17 66 72 0b 22 29 4b 81 4f 75 e4 dd 26 b5 fd) \
             0 2 (01 00 00 00)" # Get PRR mode (type): 0x1
     acpidbg -b "evaluate \_SB.PCI0.CNVW._DSM \
             (2c 17 66 72 0b 22 29 4b 81 4f 75 e4 dd 26 b5 fd) \
             0 2 (03 00 00 00)" # Get PRR status: 0x0
     acpidbg -b "evaluate \_SB.PCI0.CNVW.CNVP._RST"
     acpidbg -b "evaluate \_SB.PCI0.CNVW._DSM \
             (2c 17 66 72 0b 22 29 4b 81 4f 75 e4 dd 26 b5 fd) \
             0 2 (03 00 00 00)" # Get PRR status: 0x2
     acpidbg -b 'evaluate \_SB.PCI0.CNVW.WFDL' # 0x32
     acpidbg -b "evaluate \_SB.PCI0.CNVW._DSM \
           (2c 17 66 72 0b 22 29 4b 81 4f 75 e4 dd 26 b5 fd) \
           0 5 60"
     acpidbg -b 'evaluate \_SB.PCI0.CNVW.WFDL' # 0x3C

Change-Id: I6b9d3b2d407d458a94cc2a1695c84f5dc00f9d1a
Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/88114
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Jeremy Compostella 2025-06-16 14:41:39 -07:00 • committed by Jérémy Compostella
commit d92b6163e7
1 changed files with 87 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

102
src/drivers/wifi/generic/acpi.c
View file

@ -261,6 +261,82 @@ static void wifi_dsm_ddrrfim_func3_cb(void *ptr)
acpigen_write_return_integer(is_cnvi_ddr_rfim_enabled ? 0 : 1);
}
/*
* Function 2: Power Resource for Reset (PRR) for Wi-Fi
*
* Args3 is a buffer comparable to the following C structure:
* struct pldr_mode {
* uint16_t cmd_type;
* uint16_t cmd_payload;
* };
*
* cmd_type can take one of the following values:
* 1 - Get PRR mode;
* 2 - Set PRR mode to cmd_payload;
* 3 - Get PRR status;
*/
static void wifi_dsm_power_resource_for_reset(__always_unused void *args)
{
acpigen_write_create_word_field(ARG3_OP, 0, "CMDT");
acpigen_write_create_word_field(ARG3_OP, 2, "CMDP");
/* Get PRR mode */
acpigen_write_if_lequal_namestr_int("CMDT", 1);
{
acpigen_write_if_cond_ref_of("RSTT");
{
acpigen_write_return_namestr("RSTT");
}
acpigen_pop_len();
acpigen_write_return_integer(0);
}
acpigen_pop_len();
/* Set PRR mode */
acpigen_write_if_lequal_namestr_int("CMDT", 2);
{
acpigen_write_if_cond_ref_of("RSTT");
{
acpigen_write_store();
acpigen_emit_namestring("CMDP");
acpigen_emit_namestring("RSTT");
}
acpigen_pop_len();
acpigen_write_return_integer(0);
}
acpigen_pop_len();
/* Get last PRR status */
acpigen_write_if_lequal_namestr_int("CMDT", 3);
{
acpigen_write_if_cond_ref_of("PRRS");
{
acpigen_write_return_namestr("PRRS");
}
acpigen_pop_len();
acpigen_write_return_integer(0);
}
acpigen_pop_len();
acpigen_write_return_integer(0);
}
/*
* Function 5: Set Power Resource for Reset (PRR) reset delay for Wi-Fi
*/
static void wifi_dsm_set_prr_reset_delay(__always_unused void *args)
{
acpigen_write_if_cond_ref_of("WFDL");
{
acpigen_write_store();
acpigen_emit_byte(ARG3_OP);
acpigen_emit_namestring("WFDL");
}
acpigen_pop_len();
}
static void (*wifi_dsm_callbacks[])(void *) = {
NULL, /* Function 0 */
wifi_dsm_srd_active_channels, /* Function 1 */
@ -277,15 +353,13 @@ static void (*wifi_dsm_callbacks[])(void *) = {
wifi_dsm_11be_country_enablement, /* Function 12 */
};
/*
* The current DSM2 table is only exporting one function (function 3), some more
* functions are reserved so marking them NULL.
*/
static void (*wifi_dsm2_callbacks[])(void *) = {
NULL, /* Function 0 */
NULL, /* Function 1 */
NULL, /* Function 2 */
wifi_dsm_ddrrfim_func3_cb, /* Function 3 */
NULL, /* Function 0 */
NULL, /* Function 1 */
wifi_dsm_power_resource_for_reset, /* Function 2 */
wifi_dsm_ddrrfim_func3_cb, /* Function 3 */
NULL, /* Function 4 */
wifi_dsm_set_prr_reset_delay, /* Function 5 */
};
static const uint8_t *sar_fetch_set(const struct sar_profile *sar, size_t set_num)
@ -1117,13 +1191,11 @@ static void wifi_ssdt_write_properties(const struct device *dev, const char *sco
}
}
if (is_cnvi_ddr_rfim_enabled) {
dsm_ids[dsm_count].uuid = ACPI_DSM_RFIM_WIFI_UUID;
dsm_ids[dsm_count].callbacks = &wifi_dsm2_callbacks[0];
dsm_ids[dsm_count].count = ARRAY_SIZE(wifi_dsm2_callbacks);
dsm_ids[dsm_count].arg = &is_cnvi_ddr_rfim_enabled;
dsm_count++;
}
dsm_ids[dsm_count].uuid = ACPI_DSM_RFIM_WIFI_UUID;
dsm_ids[dsm_count].callbacks = &wifi_dsm2_callbacks[0];
dsm_ids[dsm_count].count = ARRAY_SIZE(wifi_dsm2_callbacks);
dsm_ids[dsm_count].arg = &is_cnvi_ddr_rfim_enabled;
dsm_count++;
acpigen_write_dsm_uuid_arr(dsm_ids, dsm_count);