From d855ced42936b8637a800bed282d3c2489efddad Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Wed, 24 May 2017 10:57:13 +0200 Subject: [PATCH] UPSTREAM: mb/lenovo/*60: Remove not existing DIMMs from SPD map Should result in a tiny speed bump in raminit since those addresses are not checked for present DIMMs. Checked in schematics of both Thinkpad X60 and T60 and tested to configure raminit correctly for all DIMMs populated on X60. BUG=none BRANCH=none TEST=none Change-Id: Ib52cde02578aa34de55be6e9b482ba47019b9809 Signed-off-by: Patrick Georgi Original-Commit-Id: 000cc598cbd2ab663e1192d8623171bda293b6d3 Original-Change-Id: I56c4f3176541bc75a8de3aac9f87526a77fc819b Original-Signed-off-by: Arthur Heymans Original-Reviewed-on: https://review.coreboot.org/19862 Original-Tested-by: build bot (Jenkins) Original-Reviewed-by: Paul Menzel Original-Reviewed-by: Patrick Rudolph Reviewed-on: https://chromium-review.googlesource.com/515864 Commit-Ready: Patrick Georgi Tested-by: Patrick Georgi Reviewed-by: Patrick Georgi --- src/mainboard/lenovo/t60/romstage.c | 2 +- src/mainboard/lenovo/x60/romstage.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mainboard/lenovo/t60/romstage.c b/src/mainboard/lenovo/t60/romstage.c index cb3f8bc85e..80b989fc50 100644 --- a/src/mainboard/lenovo/t60/romstage.c +++ b/src/mainboard/lenovo/t60/romstage.c @@ -172,7 +172,7 @@ void mainboard_romstage_entry(unsigned long bist) { int s3resume = 0; int dock_err; - const u8 spd_addrmap[2 * DIMM_SOCKETS] = { 0x50, 0x52, 0x51, 0x53 }; + const u8 spd_addrmap[2 * DIMM_SOCKETS] = { 0x50, 0, 0x51, 0 }; timestamp_init(get_initial_timestamp()); diff --git a/src/mainboard/lenovo/x60/romstage.c b/src/mainboard/lenovo/x60/romstage.c index 51624a009e..eddb1506bb 100644 --- a/src/mainboard/lenovo/x60/romstage.c +++ b/src/mainboard/lenovo/x60/romstage.c @@ -171,7 +171,7 @@ static void early_ich7_init(void) void mainboard_romstage_entry(unsigned long bist) { int s3resume = 0; - const u8 spd_addrmap[2 * DIMM_SOCKETS] = { 0x50, 0x52, 0x51, 0x53 }; + const u8 spd_addrmap[2 * DIMM_SOCKETS] = { 0x50, 0, 0x51, 0 }; timestamp_init(get_initial_timestamp());