erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tree: Use accessor functions for struct region fields

Browse source 
Always use the high-level API region_offset() and region_sz()
functions. This excludes the internal `region.c` code as well
as unit tests. FIT payload support was also skipped, as it
seems it never tried to use the API and would need a bigger
overhaul.

Change-Id: Iaae116a1ab2da3b2ea2a5ebcd0c300b238582834
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79904
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <service+coreboot-gerrit@felixsinger.de>
This commit is contained in:
Nico Huber 2024-01-11 18:50:50 +01:00 • committed by Martin L Roth
commit d7612e9765
4 changed files with 23 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/cpu/x86/smm/smm_module_loader.c
View file

@ -363,7 +363,7 @@ static int append_and_check_region(const struct region smram,
{
unsigned int region_counter = 0;
for (; region_counter < SMM_REGIONS_ARRAY_SIZE; region_counter++)
if (region_list[region_counter].size == 0)
if (region_sz(&region_list[region_counter]) == 0)
break;
if (region_counter >= SMM_REGIONS_ARRAY_SIZE) {