cpu/intel/sandybridge: Use enum for ACPI C states

Also remove the now unnecessary comments from the devicetree.

Change-Id: Iebbe12fd413b7a2eb1078a579e194eba821ada7c
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69292
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
This commit is contained in:
Arthur Heymans 2022-11-07 09:23:02 +01:00
commit d52bfbb6aa
7 changed files with 27 additions and 16 deletions

View file

@ -17,8 +17,8 @@ chip northbridge/intel/sandybridge
device lapic 0 on end
device lapic 0xacac off end
register "acpi_c1" = "3" # ACPI(C1) = MWAIT(C3)
register "acpi_c2" = "4" # ACPI(C2) = MWAIT(C6)
register "acpi_c1" = "CPU_ACPI_C3"
register "acpi_c2" = "CPU_ACPI_C6"
end
end

View file

@ -8,8 +8,8 @@ chip northbridge/intel/sandybridge
device lapic 0 on end
device lapic 0xacac off end
register "acpi_c2" = "4" # ACPI(C2) = MWAIT(C3)
register "acpi_c3" = "0" # ACPI(C3) = MWAIT(C7)
register "acpi_c2" = "CPU_ACPI_C6"
register "acpi_c3" = "CPU_ACPI_DISABLED"
end
end

View file

@ -23,8 +23,8 @@ chip northbridge/intel/sandybridge
device lapic 0 on end
device lapic 0xacac off end
register "acpi_c2" = "4" # ACPI(C2) = MWAIT(C6)
register "acpi_c3" = "0"
register "acpi_c2" = "CPU_ACPI_C6"
register "acpi_c3" = "CPU_ACPI_DISABLED"
end
end

View file

@ -23,8 +23,8 @@ chip northbridge/intel/sandybridge
device lapic 0 on end
device lapic 0xacac off end
register "acpi_c2" = "4" # ACPI(C2) = MWAIT(C6)
register "acpi_c3" = "0"
register "acpi_c2" = "CPU_ACPI_C6"
register "acpi_c3" = "CPU_ACPI_DISABLED"
end
end

View file

@ -17,8 +17,8 @@ chip northbridge/intel/sandybridge
device lapic 0 on end
device lapic 0xacac off end
register "acpi_c1" = "3" # ACPI(C1) = MWAIT(C3)
register "acpi_c2" = "4" # ACPI(C2) = MWAIT(C6)
register "acpi_c1" = "CPU_ACPI_C3"
register "acpi_c2" = "CPU_ACPI_C6"
end
end