erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/*/*/acpi_tables: Don't initialize already initialized fields

Browse source 
Don't initialize fields with zeroes since gnvs structs were zeroed out
in southbridge already. See

* src/southbridge/intel/*/lpc.c

Change-Id: I5228f2cdc94df722ffa687c45b4e4fd25e82df82
Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37967
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Peter Lemenkov 2019-12-26 21:17:33 +03:00 • committed by Patrick Georgi
commit d225834220
19 changed files with 0 additions and 151 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/mainboard/asrock/b75pro3-m/acpi_tables.c
View file

@ -19,14 +19,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs)
{
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
// the lid is open by default.
gnvs->lids = 1;

8
src/mainboard/asus/p8h61-m_pro/acpi_tables.c
View file

@ -19,14 +19,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs)
{
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
gnvs->tcrt = 100;
gnvs->tpsv = 90;
}

8
src/mainboard/asus/p8z77-m_pro/acpi_tables.c
View file

@ -19,14 +19,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs)
{
/* Turn off power for USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Turn off power for USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
/* critical temp that will shutdown the pc == 95C degrees */
gnvs->tcrt = 95;

8
src/mainboard/compulab/intense_pc/acpi_tables.c
View file

@ -20,14 +20,6 @@
/* FIXME: check this function. */
void acpi_create_gnvs(global_nvs_t *gnvs)
{
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
gnvs->tcrt = 100;
gnvs->tpsv = 90;
}

8
src/mainboard/gigabyte/ga-b75m-d3h/acpi_tables.c
View file

@ -19,14 +19,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs)
{
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
gnvs->tcrt = CRITICAL_TEMPERATURE;
gnvs->tpsv = PASSIVE_TEMPERATURE;
}

7
src/mainboard/gigabyte/ga-h61m-s2pv/acpi_tables.c
View file

@ -17,11 +17,4 @@
void acpi_create_gnvs(global_nvs_t *gnvs)
{
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
}

8
src/mainboard/hp/2570p/acpi_tables.c
View file

@ -19,14 +19,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs)
{
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
// the lid is open by default.
gnvs->lids = 1;

8
src/mainboard/hp/2760p/acpi_tables.c
View file

@ -17,14 +17,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs)
{
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
// the lid is open by default.
gnvs->lids = 1;

8
src/mainboard/hp/8460p/acpi_tables.c
View file

@ -19,14 +19,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs)
{
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
// the lid is open by default.
gnvs->lids = 1;

8
src/mainboard/hp/8470p/acpi_tables.c
View file

@ -17,14 +17,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs)
{
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
// the lid is open by default.
gnvs->lids = 1;

8
src/mainboard/hp/8770w/acpi_tables.c
View file

@ -17,14 +17,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs)
{
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
// the lid is open by default.
gnvs->lids = 1;

8
src/mainboard/hp/compaq_8200_elite_sff/acpi_tables.c
View file

@ -20,14 +20,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs)
{
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
gnvs->tcrt = 100;
gnvs->tpsv = 90;
}

8
src/mainboard/hp/folio_9470m/acpi_tables.c
View file

@ -19,14 +19,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs)
{
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
// the lid is open by default.
gnvs->lids = 1;

8
src/mainboard/hp/revolve_810_g1/acpi_tables.c
View file

@ -20,14 +20,6 @@
/* FIXME: check this function. */
void acpi_create_gnvs(global_nvs_t *gnvs)
{
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
// the lid is open by default.
gnvs->lids = 1;

8
src/mainboard/hp/z220_sff_workstation/acpi_tables.c
View file

@ -20,14 +20,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs)
{
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
gnvs->tcrt = 100;
gnvs->tpsv = 90;
}

8
src/mainboard/kontron/ktqm77/acpi_tables.c
View file

@ -18,14 +18,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs)
{
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
gnvs->tcrt = CRITICAL_TEMPERATURE;
gnvs->tpsv = PASSIVE_TEMPERATURE;
}

8
src/mainboard/msi/ms7707/acpi_tables.c
View file

@ -19,14 +19,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs)
{
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
gnvs->tcrt = 100;
gnvs->tpsv = 90;
}

8
src/mainboard/roda/rv11/acpi_tables.c
View file

@ -19,14 +19,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs)
{
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
/* The lid is open by default */
gnvs->lids = 1;

8
src/mainboard/sapphire/pureplatinumh61/acpi_tables.c
View file

@ -18,14 +18,6 @@
void acpi_create_gnvs(global_nvs_t *gnvs)
{
/* Disable USB ports in S3 by default */
gnvs->s3u0 = 0;
gnvs->s3u1 = 0;
/* Disable USB ports in S5 by default */
gnvs->s5u0 = 0;
gnvs->s5u1 = 0;
// the lid is open by default.
gnvs->lids = 1;