From d1f75654030711d84cf7756311c54e4b8f0fd35a Mon Sep 17 00:00:00 2001 From: Cong Yang Date: Thu, 20 Feb 2025 10:07:18 +0800 Subject: [PATCH] mb/google/skywalker: Notify EC that AP is in S0 GPIO_AP_SUSPEND_L is supposed to be high in S0, and low in S3. EC uses this pin to determine the AP power state. This pin should be set as early as possible in bootblock. BUG=b:396030112 BRANCH=none TEST=reboot pass. `powerinfo` shows S0 in EC console. Change-Id: Ib7e9eaa19d232a37b3793bcbe268ba021e456ac7 Signed-off-by: Cong Yang Reviewed-on: https://review.coreboot.org/c/coreboot/+/87793 Tested-by: build bot (Jenkins) Reviewed-by: Yu-Ping Wu Reviewed-by: Yidi Lin --- src/mainboard/google/skywalker/chromeos.c | 1 + src/mainboard/google/skywalker/gpio.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mainboard/google/skywalker/chromeos.c b/src/mainboard/google/skywalker/chromeos.c index eb310f3576..ffc0e9550b 100644 --- a/src/mainboard/google/skywalker/chromeos.c +++ b/src/mainboard/google/skywalker/chromeos.c @@ -13,6 +13,7 @@ void setup_chromeos_gpios(void) gpio_input(GPIO_GSC_AP_INT_ODL); gpio_output(GPIO_AP_EC_WARM_RST_REQ, 0); gpio_output(GPIO_XHCI_INIT_DONE, 0); + gpio_output(GPIO_AP_SUSPEND_L, 1); } void fill_lb_gpios(struct lb_gpios *gpios) diff --git a/src/mainboard/google/skywalker/gpio.h b/src/mainboard/google/skywalker/gpio.h index 1fc4674de5..22ee14d855 100644 --- a/src/mainboard/google/skywalker/gpio.h +++ b/src/mainboard/google/skywalker/gpio.h @@ -10,6 +10,7 @@ #define GPIO_EC_AP_INT_ODL GPIO(GBE_MDIO) #define GPIO_AP_EC_WARM_RST_REQ GPIO(GBE_AUX_PPS0) #define GPIO_GSC_AP_INT_ODL GPIO(GBE_AUX_PPS1) +#define GPIO_AP_SUSPEND_L GPIO(CONN_TOP_DATA) void setup_chromeos_gpios(void);