erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

nb/intel/pineview: Remove unused code

Browse source 
All the clocks are switched on anyway, so this series of if statements
isn't needed.

Change-Id: I654043fd6736caa6890fd697015c577ddaa7cd41
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: Coverity CID 13473{27-30}
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33408
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Jacob Garber 2019-06-11 14:13:04 -06:00 • committed by Martin Roth
commit d10680bbbf
1 changed files with 1 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/northbridge/intel/pineview/raminit.c
View file

@ -1141,16 +1141,7 @@ static void sdram_dlltiming(struct sysinfo *s)
MCHBAR8(0x1a8) = MCHBAR8(0x1a8) | 1;
MCHBAR32(0x1a0) = 0x551803;
if (ONLY_DIMMA_IS_POPULATED(s->dimms, 0)) {
reg8 = 0x3c;
} else if (ONLY_DIMMB_IS_POPULATED(s->dimms, 0)) {
reg8 = 0x27;
} else if (BOTH_DIMMS_ARE_POPULATED(s->dimms, 0)) {
reg8 = 0x24;
} else {
// None
reg8 = 0x3f;
}
reg8 = 0x00; //switch all clocks on anyway
MCHBAR32(0x5a0) = (MCHBAR32(0x5a0) & ~0x3f000000) | (reg8 << 24);