From d0367e38a9e5d5b86f1a33024077297e6fc55bbc Mon Sep 17 00:00:00 2001 From: Momoko Hattori Date: Fri, 7 Mar 2025 12:50:49 +0900 Subject: [PATCH] mb/google/brya/var/redrix: Enable use_gpio_for_status for touchscreen The _STA method of redrix i2c3's power resource currently always returns true. This causes the device to be powered on by the kernel in a boot critical path (in acpi_bus_init_power) and blocks it for 300ms due to the sleep in the _ON method. To prevent this sleep from blocking the boot, enable use_gpio_for_status so that the implementation of _STA returns the device's actual power state and the kernel powers on the device in another place that doesn't block boot. BUG=b:397355818 TEST=Boot the device, confirm that kernel doesn't sleep for 300ms during acpi_bus_init_power and the touchscreen works without any problems. Change-Id: I517a9477f7b59b621337c56eedbfcf17b82dc39b Signed-off-by: Momoko Hattori Reviewed-on: https://review.coreboot.org/c/coreboot/+/86749 Reviewed-by: Sam McNally Tested-by: build bot (Jenkins) --- src/mainboard/google/brya/variants/redrix/overridetree.cb | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mainboard/google/brya/variants/redrix/overridetree.cb b/src/mainboard/google/brya/variants/redrix/overridetree.cb index f26d133461..1a9f1d9b17 100644 --- a/src/mainboard/google/brya/variants/redrix/overridetree.cb +++ b/src/mainboard/google/brya/variants/redrix/overridetree.cb @@ -514,6 +514,7 @@ chip soc/intel/alderlake "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)" register "generic.stop_off_delay_ms" = "1" register "generic.has_power_resource" = "1" + register "generic.use_gpio_for_status" = "true" register "hid_desc_reg_offset" = "0x01" device i2c 0x15 on end end