From cefef5ce9914df168842bfc10f0103eb9fc1d225 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Tue, 28 Jan 2025 13:54:16 +0000 Subject: [PATCH] mb/starlabs/*: Correct the enable GPIO for WLAN These are configured incorrectly, to use the WLAN WAKE GPIOs as enable GPIOS. Correct these to use WIFI RF KILL, and disconnect the now unused WLAN WAKE GPIOs. Change-Id: I12797875acacc231e155ab4e427a950a3b1b9703 Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/86184 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier --- src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c | 2 +- src/mainboard/starlabs/starbook/variants/adl/devicetree.cb | 2 +- src/mainboard/starlabs/starbook/variants/adl/gpio.c | 2 +- src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb | 2 +- src/mainboard/starlabs/starbook/variants/adl_n/gpio.c | 2 +- src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb | 2 +- src/mainboard/starlabs/starbook/variants/rpl/gpio.c | 2 +- src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb | 2 +- src/mainboard/starlabs/starfighter/variants/rpl/gpio.c | 2 +- src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c index 6353d64d7e..5e9ca3f9f5 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c @@ -223,7 +223,7 @@ const struct pad_config gpio_table[] = { /* D12: GSPI 2 MOSI FPS */ PAD_NC(GPP_D12, NONE), /* D13: Wireless LAN Wake */ - PAD_CFG_GPO(GPP_D13, 1, PLTRST), + PAD_NC(GPP_D13, NONE), /* D14: Test Point 10 */ PAD_NC(GPP_D14, NONE), /* D15: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb index 9c1934806e..341ea4075b 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb @@ -162,7 +162,7 @@ chip soc/intel/alderlake "M.2/M 2230" "SlotDataBusWidth1X" chip soc/intel/common/block/pcie/rtd3 - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D13)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E3)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H2)" register "srcclk_pin" = "2" register "add_acpi_dma_property" = "true" diff --git a/src/mainboard/starlabs/starbook/variants/adl/gpio.c b/src/mainboard/starlabs/starbook/variants/adl/gpio.c index dae0df2eff..ec32e833d8 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl/gpio.c @@ -222,7 +222,7 @@ const struct pad_config gpio_table[] = { /* D12: GSPI 2 MOSI FPS */ PAD_NC(GPP_D12, NONE), /* D13: Wireless LAN Wake */ - PAD_CFG_GPO(GPP_D13, 1, PLTRST), + PAD_NC(GPP_D13, NONE), /* D14: CPU M.2 SSD Power Enable */ PAD_NC(GPP_D14, NONE), /* D15: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb index d9892c534e..af9e30edcd 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb @@ -170,7 +170,7 @@ chip soc/intel/alderlake "M.2/M 2230" "SlotDataBusWidth1X" chip soc/intel/common/block/pcie/rtd3 - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D13)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E3)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H2)" register "srcclk_pin" = "1" register "add_acpi_dma_property" = "true" diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c index ed759d4b6d..79a4c4c456 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c @@ -222,7 +222,7 @@ const struct pad_config gpio_table[] = { /* D12: GSPI 2 MOSI FPS */ PAD_NC(GPP_D12, NONE), /* D13: Wireless LAN Wake */ - PAD_CFG_GPO(GPP_D13, 1, PLTRST), + PAD_NC(GPP_D13, NONE), /* D14: CPU M.2 SSD Power Enable */ PAD_NC(GPP_D14, NONE), /* D15: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb index cc31831928..abc4a7a8ce 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb @@ -199,7 +199,7 @@ chip soc/intel/alderlake "M.2/M 2230" "SlotDataBusWidth1X" chip soc/intel/common/block/pcie/rtd3 - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D13)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E3)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H2)" register "srcclk_pin" = "2" register "skip_on_off_support" = "1" diff --git a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c index 4ef11d43eb..a17c00f82a 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c @@ -222,7 +222,7 @@ const struct pad_config gpio_table[] = { /* D12: GSPI 2 MOSI FPS */ PAD_NC(GPP_D12, NONE), /* D13: Wireless LAN Wake */ - PAD_CFG_GPO(GPP_D13, 1, PLTRST), + PAD_NC(GPP_D13, NONE), /* D14: CPU M.2 SSD Power Enable */ PAD_CFG_GPO(GPP_D14, 1, PLTRST), /* D15: Not Connected */ diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb index 5dfba49b06..db31d8d023 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb @@ -205,7 +205,7 @@ chip soc/intel/alderlake "M.2/M 2230" "SlotDataBusWidth1X" chip soc/intel/common/block/pcie/rtd3 - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D13)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E3)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H2)" register "srcclk_pin" = "2" register "add_acpi_dma_property" = "true" diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c index b0fb7cdc4b..23ca3e5ee2 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c @@ -227,7 +227,7 @@ const struct pad_config gpio_table[] = { /* D12: ES8336_INT_N */ PAD_NC(GPP_D12, NONE), /* D13: Wireless LAN Wake */ - PAD_CFG_GPO(GPP_D13, 1, PLTRST), + PAD_NC(GPP_D13, NONE), /* D14: CPU M.2 SSD Power Enable */ PAD_CFG_GPO(GPP_D14, 1, PLTRST), /* D15: Not Connected */ diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c index 7c614fa3a2..2ee5c67eab 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c @@ -221,7 +221,7 @@ const struct pad_config gpio_table[] = { /* D12: GSPI 2 MOSI FPS */ PAD_NC(GPP_D12, NONE), /* D13: Wireless LAN Wake */ - PAD_CFG_GPO(GPP_D13, 1, PLTRST), + PAD_NC(GPP_D13, NONE), /* D14: ALS Interrupt */ PAD_NC(GPP_D14, NONE), /* D15: Not Connected */