From ced9f91ae9cbfc6230677a74f03c1c985ba84812 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Sat, 21 Jun 2025 11:13:26 +0530 Subject: [PATCH] soc/intel/cmn: Improve comments for fw_splash_vertical_alignment enum This commit refines the comments for the fw_splash_vertical_alignment enum members in src/soc/intel/common/block/include/intelblocks/cfg.h. The redundant enum member names (e.g., FW_SPLASH_VALIGNMENT_CENTER:) have been removed from the start of each comment block. This makes the comments cleaner and more direct, focusing on the explanation of the alignment behavior rather than re-stating the enum member's name. Change-Id: Ife7a39622df1981adc09db82fecb5adc72d52d8d Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/88157 Tested-by: build bot (Jenkins) Reviewed-by: Kapil Porwal --- src/soc/intel/common/block/include/intelblocks/cfg.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/soc/intel/common/block/include/intelblocks/cfg.h b/src/soc/intel/common/block/include/intelblocks/cfg.h index 299e923d85..95ca8ccf7d 100644 --- a/src/soc/intel/common/block/include/intelblocks/cfg.h +++ b/src/soc/intel/common/block/include/intelblocks/cfg.h @@ -22,7 +22,7 @@ enum { * within the display's height. */ enum fw_splash_vertical_alignment { - /* FW_SPLASH_VALIGNMENT_CENTER: + /* * The splash image is centered vertically `(Y-axis - logo_height)/2` on the screen. * The center of the [LOGO] aligns with the vertical center of the screen. * @@ -36,7 +36,7 @@ enum fw_splash_vertical_alignment { */ FW_SPLASH_VALIGNMENT_CENTER = 0, - /* FW_SPLASH_VALIGNMENT_TOP: + /* * The splash image is aligned to the top edge of the screen. * * +---------------+ @@ -49,7 +49,7 @@ enum fw_splash_vertical_alignment { */ FW_SPLASH_VALIGNMENT_TOP = 1, - /* FW_SPLASH_VALIGNMENT_BOTTOM: + /* * The splash image is aligned to the bottom edge of the screen. * * +---------------+ @@ -62,7 +62,7 @@ enum fw_splash_vertical_alignment { */ FW_SPLASH_VALIGNMENT_BOTTOM = 2, - /* FW_SPLASH_VALIGNMENT_MIDDLE: + /* * The splash image is placed in the vertical middle `(Y-axis/2)` of the screen * (without considering the `logo height`). This means the TOP EDGE of the * [LOGO] aligns with the screen's vertical midpoint line.