From cd2a969c82755e5b60d5e66be6a56c4965a68a1b Mon Sep 17 00:00:00 2001 From: Sowmya Aralguppe Date: Mon, 21 Jul 2025 15:25:37 +0530 Subject: [PATCH] soc/intel/pantherlake: Remove storage-off related code Crashlog storage and power management in PTL is changed to a unified and persistent model,removing the need for manual SRAM power-down commands after crashlog extraction. Change-Id: I5bea1c816bbb68a4b2b21cc3be6cf118b4282fe7 Signed-off-by: Sowmya Aralguppe Reviewed-on: https://review.coreboot.org/c/coreboot/+/88512 Reviewed-by: Jamie Ryu Tested-by: build bot (Jenkins) Reviewed-by: Bora Guvendik --- src/soc/intel/pantherlake/crashlog.c | 30 +++++----------------------- 1 file changed, 5 insertions(+), 25 deletions(-) diff --git a/src/soc/intel/pantherlake/crashlog.c b/src/soc/intel/pantherlake/crashlog.c index a57a16863f..da2cbccb32 100644 --- a/src/soc/intel/pantherlake/crashlog.c +++ b/src/soc/intel/pantherlake/crashlog.c @@ -438,32 +438,12 @@ void cpu_cl_rearm(void) void cpu_cl_cleanup(void) { - /* Perform any SOC specific cleanup after reading the crashlog data from SRAM */ - uintptr_t ctrl_sts_intfc_addr = get_control_status_interface(); - - if (!ctrl_sts_intfc_addr) { - printk(BIOS_ERR, "CPU crashlog control and status interface address not valid\n"); - return; - } - - /* If storage-off is supported, turn off the PUNIT SRAM - * stroage to save power. This clears crashlog records also. + /* + * Crashlog storage and power management in PTL is changed to a unified + * and persistent model,removing the need for manual SRAM power-down + * commands after crashlog extraction. */ - - if (!cpu_cl_disc_tab.header.fields.storage_off_support) { - printk(BIOS_INFO, "CPU crashlog storage_off not supported\n"); - return; - } - - cl_punit_control_interface_t punit_ctrl_intfc; - memset(&punit_ctrl_intfc, 0, sizeof(cl_punit_control_interface_t)); - punit_ctrl_intfc.fields.set_storage_off = 1; - write32p(ctrl_sts_intfc_addr, punit_ctrl_intfc.data); - - if (!wait_and_check(CRASHLOG_PUNIT_STORAGE_OFF_MASK)) - printk(BIOS_ERR, "CPU crashlog storage_off not asserted\n"); - else - printk(BIOS_DEBUG, "CPU crashlog storage_off asserted\n"); + /* Does nothing. */ } pmc_ipc_discovery_buf_t cl_get_pmc_discovery_buf(void)