erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/google/brya/var/agah: Remove stop pin declaration for LAN

Browse source 
Currently, the system fails to enter S0ix as the stop pin declation
for LAN device will prevent system from entering suspend.
So remove the stop pin declaration.

Also add device_index=0 for the first NIC to get correct MAC
from VPD setting.

BUG=b:210970640
TEST=Build and suspend_stress_test -c 20 pass
     Check LAN works fine after resume

Change-Id: I513bf8b4bcb4d6db2eed2790fef7f6000a441274
Signed-off-by: Tony Huang <tony-huang@quanta.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65123
Reviewed-by: Ivy Jian <ivy.jian@quanta.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
This commit is contained in:
Tony Huang 2022-06-14 11:09:30 +08:00 • committed by Felix Held
commit cc89a76a10
2 changed files with 3 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/mainboard/google/brya/variants/agah/gpio.c
View file

@ -58,8 +58,8 @@ static const struct pad_config override_gpio_table[] = {
PAD_NC_LOCK(GPP_D0, NONE, LOCK_CONFIG),
/* D1 : ISH_GP1 ==> NC */
PAD_NC_LOCK(GPP_D1, NONE, LOCK_CONFIG),
/* D2 : ISH_GP2 ==> LAN_PR_ISOLATE_ODL */
PAD_CFG_GPO_LOCK(GPP_D2, 1, LOCK_CONFIG),
/* D2 : ISH_GP2 ==> LAN_PE_ISOLATE_ODL */
PAD_CFG_GPO(GPP_D2, 1, DEEP),
/* D3 : ISH_GP3 ==> NC */
PAD_NC_LOCK(GPP_D3, NONE, LOCK_CONFIG),
/* D5 : SRCCLKREQ0# ==> GPU_CLKREQ_ODL */

5
src/mainboard/google/brya/variants/agah/overridetree.cb
View file

@ -166,11 +166,8 @@ chip soc/intel/alderlake
}"
chip drivers/net
register "customized_leds" = "0x05af"
register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D2)"
register "stop_delay_ms" = "12" # NIC needs time to quiesce
register "stop_off_delay_ms" = "1"
register "has_power_resource" = "1"
register "wake" = "GPE0_DW0_07"
register "device_index" = "0"
device pci 00.0 on end
end
end #RTL8111H Ethernet NIC