erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

veyron_danger: Turn on backlight enable before VCC_LCD

Browse source 
On current Danger boards, VCC_LCD is gated by BL_EN. Thus we
need to enable BL_EN in order to power on the display so that
we can read the EDID and set things up.

Later board revisions may change this ordering, but for now it
doesn't seem to be causing a significant issues (no noticable
"snow" or other corruption using Pepto display).

BUG=none
BRANCH=none
TEST=booted on Danger, saw dev mode screen come up

Reviewed-on: https://chromium-review.googlesource.com/266913
Reviewed-by: Julius Werner <jwerner@chromium.org>
Change-Id: Iaf17cc4682bd3c46f62cba789e3ecf8d5a474362
Signed-off-by: David Hendricks <dhendrix@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/284082
This commit is contained in:
David Hendricks 2015-04-22 15:05:18 -07:00 • committed by ChromeOS Commit Bot
commit cc0b93a9d6
2 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/mainboard/google/veyron_danger/board.h
View file

@ -25,6 +25,7 @@
#define GPIO_BACKLIGHT GPIO(7, A, 3)
#define GPIO_RESET GPIO(0, B, 5)
#define GPIO_LCDC_BL GPIO(7, A, 7)
/* TODO: move setup_chromeos_gpios() here once bootblock code is in mainboard */

13
src/mainboard/google/veyron_danger/mainboard.c
View file

@ -93,6 +93,17 @@ static void configure_vop(void)
/* lcdc(vop) iodomain select 1.8V */
writel(RK_SETBITS(1 << 0), &rk3288_grf->io_vsel);
/*
* BL_EN gates VCC_LCD. This might be changed in future revisions
* of the board so that the display can be stablized before we
* turn on the backlight.
*
* To minimize display corruption, turn off LCDC_BL before
* powering on the backlight.
*/
gpio_output(GPIO_BACKLIGHT, 1); /* BL_EN */
gpio_output(GPIO_LCDC_BL, 0);
rk808_configure_switch(2, 1); /* VCC18_LCD (HDMI_AVDD_1V8) */
rk808_configure_ldo(7, 1000); /* VDD10_LCD (HDMI_AVDD_1V0) */
rk808_configure_switch(1, 1); /* VCC33_LCD */
@ -131,5 +142,5 @@ void lb_board(struct lb_header *header)
void mainboard_power_on_backlight(void)
{
gpio_output(GPIO_BACKLIGHT, 1); /* BL_EN */
gpio_output(GPIO_LCDC_BL, 1);
}