From cb7d2ebe5c7f34d84d22f0e1f5cf66c5d1c08bda Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Wed, 4 Jun 2025 12:26:20 +0100 Subject: [PATCH] mb/starlabs/starbook/{kbl,cml,tgl}: Remove generic.detect from the touchpad These boards only ever used one trackpad, so there is no need for this to be set. Change-Id: Ibabb663a83eea5f06c683cf2854ceed0487baf51 Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/87949 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier --- src/mainboard/starlabs/starbook/variants/cml/devicetree.cb | 1 - src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb | 1 - src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb | 1 - 3 files changed, 3 deletions(-) diff --git a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb index 4d04df714f..0fb641be36 100644 --- a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb @@ -148,7 +148,6 @@ chip soc/intel/cannonlake register "generic.hid" = ""STAR0001"" register "generic.desc" = ""Touchpad"" register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_B3_IRQ)" - register "generic.detect" = "1" register "hid_desc_reg_offset" = "0x20" device i2c 2c on end end diff --git a/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb index 0f1c922acd..f80003f05a 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb @@ -75,7 +75,6 @@ chip soc/intel/skylake register "generic.hid" = ""STAR0001"" register "generic.desc" = ""Touchpad"" register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C23_IRQ)" - register "generic.detect" = "1" register "hid_desc_reg_offset" = "0x20" device i2c 2c on end end diff --git a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb index 69a9c1af33..9f660d5cb2 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb @@ -175,7 +175,6 @@ chip soc/intel/tigerlake register "generic.hid" = ""STAR0001"" register "generic.desc" = ""Touchpad"" register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C8_IRQ)" - register "generic.detect" = "1" register "hid_desc_reg_offset" = "0x20" device i2c 2c on end end