erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

toolchain: get rid of some bashisms

Browse source 
On Ubuntu /bin/sh is symlinked to /bin/dash. The
current toolchain.inc was doing some things that
dash doesn't support. Make the shell callouts more
conforming to the POSIX sh standard.

BUG=None
BRANCH=None
TEST=Built rush.

Change-Id: I26b6b82b8d6158c9029e8be9e7c088ca9e207f21
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: http://review.coreboot.org/5701
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: https://chromium-review.googlesource.com/204400
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
This commit is contained in:
Aaron Durbin 2014-05-08 11:14:41 -05:00 • committed by chrome-internal-fetch
commit cb66210625
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
toolchain.inc
View file

@ -66,14 +66,14 @@ STRIP_$(1) := $(STRIP_$(2))
READELF_$(1) := $(READELF_$(2))
INCLUDES_$(1) = $$(INCLUDES) -Isrc/arch/$(ARCHDIR-$(2))/include
CFLAGS_$(1) = $$(CFLAGS_common) $$(INCLUDES_$(1)) $(CFLAGS_$(2))
LIBGCC_FILE_NAME_$(1) = $(shell test -r `$(CC_$(2)) -print-libgcc-file-name` && \
LIBGCC_FILE_NAME_$(1) = $(shell [ -r `$(CC_$(2)) -print-libgcc-file-name` ] && \
$(CC_$(2)) -print-libgcc-file-name)
endef
# initialize standard toolchain (CC,AS and others) for given stage
# @1 : stage for which the toolchain is to be initialized
init_standard_toolchain = \
$(eval stage_caps := $(shell tr '[:lower:]' '[:upper:]' <<< $(1))) \
$(eval stage_caps := $(shell printf "%s" $(1) | tr '[:lower:]' '[:upper:]' )) \
$(eval $(call set_stage_toolchain,$(stage_caps))) \
$(eval $(call create_class_compiler,$(1),$(ARCH-$(stage_caps)-y))) \
$(eval $(call set_stage_libgcc,$(1)))
@ -87,4 +87,4 @@ $(eval $(call create_class_compiler,arm64,aarch64))
$(eval $(call toolchain_to_dir))
$(eval $(call init_stages))
$(eval $(call init_stages))