erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/intel/alderlake: Do lazy reset after disabling UFS

Browse source 
If the mainboard expects upcoming reset, then skip the reset after
disabling UFS. This will reduce the number of resets during firmware
update.

BUG=b:375444631
TEST=Build Brox BIOS image and boot to OS. Perform a firmware update and
confirm that the number of reset is reduced by 2 resets.

Change-Id: I4399555302ec23a76f89f406f437f311eea0ef99
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84935
Reviewed-by: Subrata Banik <subratabanik@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
This commit is contained in:
Karthikeyan Ramasubramanian 2024-10-30 10:16:11 -06:00 • committed by Subrata Banik
commit cb11ad06c2
2 changed files with 17 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/soc/intel/alderlake/include/soc/romstage.h
View file

@ -20,4 +20,15 @@ enum board_type {
BOARD_TYPE_SERVER = 8
};
/*
* Default implementation indicates that the mainboard does not expect another reset.
* Mainboards can override the default implementation to indicate whether they expect
* another reset eg. FW Sync for another component on the mainboard. Some silicon init
* code eg. disabling UFS, can use this hint to suppress any redundant resets that they
* trigger. If the mainboard does not expect another reset, then the silicon init code
* can trigger their required reset.
*
* Return: true when the mainboard expects another reset, false otherwise.
*/
bool mainboard_expects_another_reset(void);
#endif /* _SOC_ROMSTAGE_H_ */

7
src/soc/intel/alderlake/romstage/romstage.c
View file

@ -32,6 +32,11 @@
#define PCR_PSFX_T0_SHDW_PCIEN 0x1C
#define PCR_PSFX_T0_SHDW_PCIEN_FUNDIS (1 << 8)
bool __weak mainboard_expects_another_reset(void)
{
return false;
}
static void disable_ufs(void)
{
/* disable USF0 */
@ -185,7 +190,7 @@ void mainboard_romstage_entry(void)
(CONFIG(USE_UNIFIED_AP_FIRMWARE_FOR_UFS_AND_NON_UFS))) {
printk(BIOS_INFO, "Disabling UFS controllers\n");
disable_ufs();
if (ps->prev_sleep_state == ACPI_S5) {
if (ps->prev_sleep_state == ACPI_S5 && !mainboard_expects_another_reset()) {
printk(BIOS_INFO, "Warm Reset after disabling UFS controllers\n");
system_reset();
}