erebion/coreboot
Watch
1
0
Fork
You've already forked coreboot
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

UPSTREAM: google/slippy: fix internal mic for falco/wolf variants

Browse source 
The HDA verb for falco/wolf's internal mic was wrong, preventing the mic
from working properly in Windows and macOS (the Linux driver overrides
the verb table, so wasn't affected). Set the verb connector/jack bits
properly, to no connector / no jack detect, in order to fix.

Also, make (2) small non-functional fixes:

On falco, NID 0x1A was being disabled twice (instead of 0x1A and 0x1B
both being disabled - copy/paste error).
On wolf, NID 0x19 was set to an internal analog mic, where it should have
been disabled (again, copy/paste error).

Both these errors were introduced when consolidating/upstreaming
and were not present in the original Chromium sources.

Test: boot Windows [8/8.1/10] and verify mic functional with Realtek
drivers on both falco and wolf.

BUG=none
BRANCH=none
TEST=none

Change-Id: Ibf026149b4ca2e28954cdd1d9e3c24bebfc63a57
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Original-Commit-Id: 6fa36c9c2c
Original-Change-Id: I9c343dda4762f0b1f814318c155e22c59d2da8db
Original-Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Original-Reviewed-on: https://review.coreboot.org/19262
Original-Tested-by: build bot (Jenkins)
Original-Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://chromium-review.googlesource.com/480291
This commit is contained in:
Matt DeVillier 2017-04-12 14:25:56 -05:00 • committed by chrome-bot
commit c93d1fa154
2 changed files with 5 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/mainboard/google/slippy/variants/falco/hda_verb.c
View file

@ -32,7 +32,7 @@ const u32 cim_verb_data[] = {
/* Pin Widget Verb Table */
/* Pin Complex (NID 0x12) DMIC - interior mobile lid */
AZALIA_PIN_CFG(0x0, 0x12, 0xb7a61010),
AZALIA_PIN_CFG(0x0, 0x12, 0xb7a60110),
/* Pin Complex (NID 0x14) SPKR-OUT PORTD */
// group 1, front left/right
@ -58,7 +58,7 @@ const u32 cim_verb_data[] = {
AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
/* Pin Complex (NID 0x1B) LINE2 PORTE - Disabled */
AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
AZALIA_PIN_CFG(0x0, 0x1b, 0x411111f0),
/* Pin Complex (NID 0x1d) PCBeep */
// eapd low on ex-amp, laptop, custom enable

10
src/mainboard/google/slippy/variants/wolf/hda_verb.c
View file

@ -37,7 +37,7 @@ const u32 cim_verb_data[] = {
/* Pin Widget Verb Table */
/* Pin Complex (NID 0x12) DMIC - interior mobile lid */
AZALIA_PIN_CFG(0x0, 0x12, 0xb7a61010),
AZALIA_PIN_CFG(0x0, 0x12, 0xb7a60110),
/* Pin Complex (NID 0x14) SPKR-OUT - Internal Speakers */
// group 1, cap 0
@ -59,12 +59,8 @@ const u32 cim_verb_data[] = {
// connector, External left panel
AZALIA_PIN_CFG(0x0, 0x19, 0x03a11020),
/* Pin Complex (NID 0x1A) LINE1 - Internal Mic */
// group 1, cap 1
// no connector, no jack detect
// mic in, analog connection
// Fixed function, internal, Location N/A
AZALIA_PIN_CFG(0x0, 0x1a, 0x90a70111),
/* Pin Complex (NID 0x1A) LINE1 PORTC - Disabled */
AZALIA_PIN_CFG(0x0, 0x1a, 0x411111f0),
/* Pin Complex (NID 0x1B) LINE2 - Disabled */
AZALIA_PIN_CFG(0x0, 0x1b, 0x411111f0),