From c8e6ca1d812d9039f8c44830dd1ecc5693a9d1bf Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Tue, 18 Mar 2025 13:30:37 +0000 Subject: [PATCH] mb/starlabs/*: Disable HPD for USB Type-C ports Display-Alt Mode doesn't require HPD to be set here, so remove it. Change-Id: I6e03c481584ff2b0bbb06d1d21f31fd0db4ecb27 Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/86915 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb | 1 - src/mainboard/starlabs/starbook/variants/adl/devicetree.cb | 1 - src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb | 1 - src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb | 1 - src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb | 1 - src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb | 2 -- 6 files changed, 7 deletions(-) diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb b/src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb index 4ff591d5f9..25ae635491 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb @@ -22,7 +22,6 @@ chip soc/intel/alderlake register "ddi_ports_config" = "{ [DDI_PORT_A] = DDI_ENABLE_HPD, [DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, - [DDI_PORT_1] = DDI_ENABLE_HPD, }" end device ref tcss_xhci on diff --git a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb index e63d0f8558..dd6500ef73 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb @@ -34,7 +34,6 @@ chip soc/intel/alderlake register "ddi_ports_config" = "{ [DDI_PORT_A] = DDI_ENABLE_HPD, [DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, - [DDI_PORT_1] = DDI_ENABLE_HPD, }" end device ref gna on end diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb index 0140f252de..4f6368a428 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb @@ -54,7 +54,6 @@ chip soc/intel/alderlake register "ddi_ports_config" = "{ [DDI_PORT_A] = DDI_ENABLE_HPD, [DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, - [DDI_PORT_1] = DDI_ENABLE_HPD, }" end device ref gna on end diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb index abf9802122..bd22901f01 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb @@ -36,7 +36,6 @@ chip soc/intel/alderlake register "ddi_ports_config" = "{ [DDI_PORT_A] = DDI_ENABLE_HPD, [DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, - [DDI_PORT_1] = DDI_ENABLE_HPD, }" end device ref pcie4_0 on # SSD x4 diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb index cb5c8767d3..479e05e4f8 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb @@ -35,7 +35,6 @@ chip soc/intel/alderlake register "ddi_ports_config" = "{ [DDI_PORT_A] = DDI_ENABLE_HPD, [DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, - [DDI_PORT_1] = DDI_ENABLE_HPD, }" end device ref pcie4_0 on # SSD x4 diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb index 52bd80b030..f27e41bf32 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb @@ -64,8 +64,6 @@ chip soc/intel/alderlake register "ddi_ports_config" = "{ [DDI_PORT_A] = DDI_ENABLE_HPD, [DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, - [DDI_PORT_1] = DDI_ENABLE_HPD, - [DDI_PORT_2] = DDI_ENABLE_HPD, }" end device ref gna on end