From c74610afae219d118b25d59479333f50e89da88d Mon Sep 17 00:00:00 2001 From: Wentao Qin Date: Tue, 18 Feb 2025 14:25:02 +0800 Subject: [PATCH] soc/mediatek/mt8189: Shut down PMIC on power key long press Currently on power key long press, PMIC will be reset. It would cause an unwanted reset pulse in the power-off sequence. To match expected sequence, change PMIC behavior to "force shutdown". BUG=b:395848137 BRANCH=none TEST=long-pressing power key doesn't trigger PMIC_AP_RST_L pulse Change-Id: Ia8fb9f4a1ffe05955fca51a58468ba338ef8e12d Signed-off-by: Haikun Zhou Reviewed-on: https://review.coreboot.org/c/coreboot/+/87798 Tested-by: build bot (Jenkins) Reviewed-by: Yidi Lin Reviewed-by: Yu-Ping Wu --- src/soc/mediatek/mt8189/mt6359p.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/soc/mediatek/mt8189/mt6359p.c b/src/soc/mediatek/mt8189/mt6359p.c index 0f899a337a..7b399abf0f 100644 --- a/src/soc/mediatek/mt8189/mt6359p.c +++ b/src/soc/mediatek/mt8189/mt6359p.c @@ -31,7 +31,8 @@ static const struct pmic_setting init_setting[] = { {0xA08, 0x1, 0x1, 0}, {0xA0C, 0x300, 0x300, 0}, {0xA10, 0x0, 0x4000, 0}, - {0xA12, 0x1E0, 0x1E0, 0}, + /* Force shutdown on power key long press */ + {0xA12, 0x1F2, 0x1F2, 0}, {0xA24, 0xFFFF, 0xFFFF, 0}, {0xA26, 0xFFE0, 0xFFE0, 0}, {0xA2C, 0xC0DF, 0xC0DF, 0},