erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/mediatek/common: Add read16/write16 support for PMIF

Browse source 
This patch is prepared for MT8196 PMIF driver.

BUG=none
TEST=emerge-corsola coreboot; emerge-geralt coreboot

Change-Id: I3adbbaaf247a8bbd99627cf089b5b55fcf4fb115
Signed-off-by: Yidi Lin <yidilin@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84774
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
This commit is contained in:
Yidi Lin 2024-10-15 17:11:28 +08:00 • committed by Yidi Lin
commit c661933a24
2 changed files with 16 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/soc/mediatek/common/include/soc/pmif_common.h
View file

@ -30,6 +30,8 @@ struct pmif {
u32 pmifid;
void (*read)(struct pmif *arb, u32 slvid, u32 reg, u32 *data);
void (*write)(struct pmif *arb, u32 slvid, u32 reg, u32 data);
void (*read16)(struct pmif *arb, u32 slvid, u32 reg, u16 *data);
void (*write16)(struct pmif *arb, u32 slvid, u32 reg, u16 data);
u32 (*read_field)(struct pmif *arb, u32 slvid, u32 reg, u32 mask, u32 shift);
void (*write_field)(struct pmif *arb, u32 slvid, u32 reg, u32 val, u32 mask, u32 shift);
int (*is_pmif_init_done)(struct pmif *arb);
@ -86,6 +88,8 @@ void pmwrap_interface_init(void);
int mtk_pmif_init(void);
void pmif_spmi_read(struct pmif *arb, u32 slvid, u32 reg, u32 *data);
void pmif_spmi_write(struct pmif *arb, u32 slvid, u32 reg, u32 data);
void pmif_spmi_read16(struct pmif *arb, u32 slvid, u32 reg, u16 *data);
void pmif_spmi_write16(struct pmif *arb, u32 slvid, u32 reg, u16 data);
u32 pmif_spmi_read_field(struct pmif *arb, u32 slvid, u32 reg, u32 mask, u32 shift);
void pmif_spmi_write_field(struct pmif *arb, u32 slvid, u32 reg,
u32 val, u32 mask, u32 shift);

12
src/soc/mediatek/common/pmif.c
View file

@ -74,6 +74,18 @@ void pmif_spmi_write(struct pmif *arb, u32 slvid, u32 reg, u32 data)
pmif_send_cmd(arb, 1, PMIF_CMD_EXT_REG_LONG, slvid, reg, NULL, data, 1);
}
void pmif_spmi_read16(struct pmif *arb, u32 slvid, u32 reg, u16 *data)
{
u32 rdata = 0;
pmif_send_cmd(arb, 0, PMIF_CMD_EXT_REG_LONG, slvid, reg, &rdata, 0, 2);
*data = (u16)rdata;
}
void pmif_spmi_write16(struct pmif *arb, u32 slvid, u32 reg, u16 data)
{
pmif_send_cmd(arb, 1, PMIF_CMD_EXT_REG_LONG, slvid, reg, NULL, data, 2);
}
u32 pmif_spmi_read_field(struct pmif *arb, u32 slvid, u32 reg, u32 mask, u32 shift)
{
u32 data;