From c62b3a24d849e98ca30042678b1fb9d1717ebbac Mon Sep 17 00:00:00 2001 From: "Ronald G. Minnich" Date: Sat, 26 Jan 2008 04:07:14 +0000 Subject: [PATCH] I hope I am not overstepping the boundaries here, but I feel this is a cosmetic comment as well. We just did lots of coding work to make sure we could call vsmbios. So let's actually call it! P.S. If this is NOT considered a cosmetic comment, feel free to yell at me :-) Signed-off-by: Ronald G. Minnich Acked-by: Ronald G. Minnich git-svn-id: svn://coreboot.org/repository/coreboot-v3@563 f3766cd6-281f-0410-b1cd-43a5c92072e9 --- northbridge/amd/geodelx/geodelx.c | 5 +++-- northbridge/amd/geodelx/vsmsetup.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/northbridge/amd/geodelx/geodelx.c b/northbridge/amd/geodelx/geodelx.c index 4e04e95589..8d6c0a04ae 100644 --- a/northbridge/amd/geodelx/geodelx.c +++ b/northbridge/amd/geodelx/geodelx.c @@ -313,6 +313,8 @@ static void geodelx_pci_domain_set_resources(struct device *dev) */ static void geodelx_pci_domain_phase2(struct device *dev) { + void do_vsmbios(void); + printk(BIOS_SPEW, ">> Entering northbridge.c: %s\n", __FUNCTION__); northbridge_init_early(); @@ -322,9 +324,8 @@ static void geodelx_pci_domain_phase2(struct device *dev) printk(BIOS_SPEW, "Before VSA:\n"); /* print_conf(); */ -#warning Not doing vsm bios -- linux will fail. /* Do the magic stuff here, so prepare your tambourine ;) */ - /* do_vsmbios(); */ + do_vsmbios(); printk(BIOS_SPEW, "After VSA:\n"); /* print_conf(); */ diff --git a/northbridge/amd/geodelx/vsmsetup.c b/northbridge/amd/geodelx/vsmsetup.c index 7ed46fd936..dc730a3953 100644 --- a/northbridge/amd/geodelx/vsmsetup.c +++ b/northbridge/amd/geodelx/vsmsetup.c @@ -168,7 +168,7 @@ u32 VSA_msrRead(u32 msrAddr) return eax; } -void do_vsmbios(void *bios) +void do_vsmbios(void) { unsigned char *buf; int i;