erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/amd/glinda: Don't let OS put debug UART into D3

Browse source 
When using CONFIG_CONSOLE_SERIAL prevent the OS from putting the
debug uart into D3 state. In the D3 state it's not operating any
more, and the user cannot read debug messages on early kernel boot
or on shutdown any more.

For release builds CONFIG_CONSOLE_SERIAL should not be set and the
device can be put into powersave mode.

Change-Id: Id6b6a4d0a053a5e14e54cf623974376992f0abd8
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/87803
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Alicja Michalska <ahplka19@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Patrick Rudolph 2025-05-22 15:36:43 +02:00 • committed by Matt DeVillier
commit c615de7248
1 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/soc/amd/glinda/acpi/mmio.asl
View file

@ -94,8 +94,9 @@ Device (FUR0)
{
Return (STAT)
}
#if (!CONFIG(CONSOLE_SERIAL) || !CONFIG(AMD_SOC_CONSOLE_UART) || CONFIG_UART_FOR_CONSOLE != 0)
AOAC_DEVICE(FCH_AOAC_DEV_UART0, 0)
#endif
}
Device (FUR1) {
@ -131,8 +132,9 @@ Device (FUR1) {
{
Return (STAT)
}
#if (!CONFIG(CONSOLE_SERIAL) || !CONFIG(AMD_SOC_CONSOLE_UART) || CONFIG_UART_FOR_CONSOLE != 1)
AOAC_DEVICE(FCH_AOAC_DEV_UART1, 0)
#endif
}
Device (FUR2) {
@ -168,8 +170,9 @@ Device (FUR2) {
{
Return (STAT)
}
#if (!CONFIG(CONSOLE_SERIAL) || !CONFIG(AMD_SOC_CONSOLE_UART) || CONFIG_UART_FOR_CONSOLE != 2)
AOAC_DEVICE(FCH_AOAC_DEV_UART2, 0)
#endif
}
Device (FUR3) {
@ -205,8 +208,9 @@ Device (FUR3) {
{
Return (STAT)
}
#if (!CONFIG(CONSOLE_SERIAL) || !CONFIG(AMD_SOC_CONSOLE_UART) || CONFIG_UART_FOR_CONSOLE != 3)
AOAC_DEVICE(FCH_AOAC_DEV_UART3, 0)
#endif
}
Device (FUR4) {